Skip to content

London | 26-ITP-May | Dipa Sarker | Sprint 3 | Implement and rewrite final#1470

Open
Dipa-Sarker wants to merge 4 commits into
CodeYourFuture:mainfrom
Dipa-Sarker:Coursework/sprint-3-implement-and-rewrite-final
Open

London | 26-ITP-May | Dipa Sarker | Sprint 3 | Implement and rewrite final#1470
Dipa-Sarker wants to merge 4 commits into
CodeYourFuture:mainfrom
Dipa-Sarker:Coursework/sprint-3-implement-and-rewrite-final

Conversation

@Dipa-Sarker

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  1. Implemented the required functionality for the angle type, proper fraction and card value logic.
  2. Rewrote and expanded the tests using Jest.
  3. Added test cases to verify expected behavior and improve test coverage.
  4. Refactored the implementation where needed to ensure the code passes all Jest tests.

@Dipa-Sarker

Copy link
Copy Markdown
Author

Hello Reviewers,
I just wanted to inform that, I made several mistakes creating branching for each of the sprints (Sprint-1, Sprint-2, Sprint-3/implement and re-write tests, Sprint-3/Practice-tdd. After so many attempts I was able to create separate branches and for that reason I named this branch "implement and re-write final". I hope I will more conscious about this issue in near future. Thank you.

@Dipa-Sarker Dipa-Sarker added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant