London | 26-ITP-May | Liridona Shehu | Sprint 3 | Implement and rewrite by shehu-dona · Pull Request #1474 · CodeYourFuture/Module-Structuring-and-Testing-Data

shehu-dona · 2026-07-06T20:14:48Z

Learners, PR Template

Self checklist

[ x] I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
[ x ] My changes meet the requirements of the task
[ x ] I have tested my changes
[ x ] My changes follow the style guide

Changelist

A PR with exercises using Jest

Luro91

I have a couple of comments

Luro91 · 2026-07-09T05:24:11Z

+  else if( angle > 180  && angle < 360){
+    return "Reflex angle";
+  }
+  else return "Invalid angle";


FYI: You don't need the else here as the code will only run if no other condition was true

Luro91 · 2026-07-09T05:24:41Z

+  if(  angle > 0 && angle < 90){
+    return "Acute angle";
+  }
+  else if  (angle === 90){
+    return  "Right angle";
+  }
+  else if ( angle > 90 && angle < 180){
+    return "Obtuse angle";
+  }
+  else if(angle === 180){
+    return "Straight angle";
+  }
+  else if( angle > 180  && angle < 360){


I see some white spaces in the conditions that are not needed. How can you ensure consistent formatting in your code?

Luro91 · 2026-07-09T05:26:21Z

+test(`should return "Invalid angle" when (180 < angle < 360)`, () => {
+  // Test various invalid angles, including boundary cases
+  expect(getAngleType(0)).toEqual("Invalid angle");
+  expect(getAngleType(360)).toEqual("Invalid angle");


You could add 2 test cases that are not boundary cases

Luro91 · 2026-07-09T05:28:01Z

+// Special case: numerator is negative is a proper fraction
+test(`should return false when numerator is negative value`, () => {
+  expect(isProperFraction(-1, 2)).toEqual(false);
+});
+
+
+// Special case: denominator is negative is a proper fraction


The comments say is a prober fracteion but the function should return false. This is confusing

Luro91 · 2026-07-09T05:28:28Z

+});
+
+
+// Special case: negative numerator with smaller value then negative dominator is a proper fraction


The comments say is a prober fracteion but the function should return false. This is confusing

Luro91 · 2026-07-09T05:29:14Z

+  const validRanks = ["A", "2", "3", "4", "5", "6", "7", "8", "9", "10", "J", "Q", "K"];
+  const validSuits = ["♠", "♥", "♦", "♣"];
+
+  let isValidRank = validRanks.includes(rank);
+  let isValidSuit = validSuits.includes(suit);
+
+
+
+// Invalid  Card
+if( !isValidRank || !isValidSuit ){
+  throw new Error("Invalid Card")


Thats a nice way of checking if the input is valid. By expliciting stating all allowed values that code is easy to understand

Luro91 · 2026-07-09T05:30:11Z

+// test(`Should throw an error when given an invalid card`, () => {
+//   expect(() => getCardValue("1♠")).toThrow();
+//   expect(() => getCardValue("Z♦")).toThrow();
+//   expect(() => getCardValue("11♥")).toThrow();
+//   expect(() => getCardValue("")).toThrow();
+// });
+


Why is this code commented out?

dona-shehu added 22 commits June 16, 2026 23:35

capitalize function, str declaration

7fd7710

Declaration and scope

88d76b4

Function parameters

b6def45

Add return a * b

d06f9a3

Sum function fixed return

c15a48e

Function with no parameter fixed

66ddc97

Calculate BMI

b82f302

Capitalize function

491605b

Convert pence to pound function

b8a684c

Removed comments

095f72d

Add 2p example

0a4c587

Time format pad()

4aa639f

Fixed variable declaration for bodyMassIndex

892bb92

implement, 1-get-angle-type.

4bc146e

implement, 2-is-proper-fraction

4ccf833

Implement, 3-get-card-value

4b20e69

Add comments to tests

6f270d2

Update error message

0799ea5

Add tests in Jest syntax

956f635

Add test in Jest syntax

5cec9c4

Used array to validate rank & suit

1096cc2

Add test in Jest syntax

6caf04c