Birmingham | 26-ITP-May | Tobias Amaechina | Sprint 3 | implement and rewrite-test with jest#1476
Open
Tobias-Amaechina wants to merge 81 commits into
Conversation
…intor is positive
…nator is positive
…nator is negative
…are -ve, however the numerator is less than denominator in absolute terms
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
1 Full Implementation of getCardValue
Added complete logic for parsing card strings.
Validates both rank and suit according to the rules of a standard 52‑card deck.
Returns correct numerical values:
Ace → 11
Face cards → 10
Number cards → their numeric value
Throws descriptive errors for invalid input.
Rewritten and Expanded Test Suite
Replaced legacy assertions with clearer, structured tests.
Added coverage for:
All valid card types
All face cards
Ace handling
Numeric cards
Error cases (invalid rank, invalid suit, missing suit, missing rank, non‑string input, malformed card formats)
Ensures the function behaves correctly across edge cases.