Skip to content

Birmingham | 26-SDC-Mar | Chioma Okeke | Sprint 3 | Implement Shell Tools#445

Open
JanefrancessC wants to merge 7 commits into
CodeYourFuture:mainfrom
JanefrancessC:implement-shell-tools
Open

Birmingham | 26-SDC-Mar | Chioma Okeke | Sprint 3 | Implement Shell Tools#445
JanefrancessC wants to merge 7 commits into
CodeYourFuture:mainfrom
JanefrancessC:implement-shell-tools

Conversation

@JanefrancessC

@JanefrancessC JanefrancessC commented Mar 30, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Completed exercises in ./implement-shell-tools

@JanefrancessC JanefrancessC added 🐋 Size X-Large 8-16 hours 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Tools The name of the module. labels Apr 1, 2026
SlideGauge
SlideGauge reviewed May 30, 2026
View reviewed changes

@SlideGauge SlideGauge left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, I got a couple of notes from my side, address them please

Comment thread .gitignore
@@ -1 +1,2 @@
node_modules
demo*

@SlideGauge SlideGauge May 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need demo in ignores?

@JanefrancessC JanefrancessC May 30, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created some demo files for my class presentation. I didn't want git to track the changes

Comment thread implement-shell-tools/cat/customCat.js Outdated
Comment thread implement-shell-tools/cat/customCat.js Outdated
Comment thread implement-shell-tools/cat/customCat.js Outdated
Comment thread implement-shell-tools/ls/customLs.js Outdated
Comment thread implement-shell-tools/wc/customWc.js Outdated
@SlideGauge SlideGauge added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 30, 2026
@JanefrancessC

JanefrancessC commented May 30, 2026

Copy link
Copy Markdown
Author

Good job, I got a couple of notes from my side, address them please

Thank you. I will address the notes asap and refactor accordingly.

@JanefrancessC JanefrancessC added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@SlideGauge SlideGauge SlideGauge left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Module-Tools The name of the module. Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. 🐋 Size X-Large 8-16 hours 📅 Sprint 3 Assigned during Sprint 3 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JanefrancessC @SlideGauge