This repository was archived by the owner on Aug 17, 2024. It is now read-only.
Added new files to my post.json file#9
Open
Seraphineyoung wants to merge 2 commits intoCodeYourFuture:masterfrom
Open
Added new files to my post.json file#9Seraphineyoung wants to merge 2 commits intoCodeYourFuture:masterfrom
Seraphineyoung wants to merge 2 commits intoCodeYourFuture:masterfrom
Conversation
MatthewWood
reviewed
Jul 21, 2018
server.js
Outdated
| @@ -0,0 +1,48 @@ | |||
| var fs = require("fs"); | |||
| var express = require("express"); | |||
| var express = require("express"); | |||
There was a problem hiding this comment.
No need to import express twice here. Also, try to use consts when importing modules. vars have become outdated. https://medium.com/javascript-scene/javascript-es6-var-let-or-const-ba58b8dcde75
| ) {}); | ||
| res.send("Yay Node Girls!"); | ||
|
|
||
| // if (error) { |
There was a problem hiding this comment.
it's always a good idea to check for errors :) It's normally the first thing you do before processing any info:
fs.readFile(__dirname + "/data/posts.json", function(error, file) {
if (error) {
console.log(error)
} else {
// do all the logic here
}
});
Author
There was a problem hiding this comment.
Thanks for the feedback, will incorporate this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new blog post ..Handlebars in progress