Closes #333 - Negative disability feedback#357
Open
reekypete wants to merge 3 commits into
Open
Conversation
techieshark
requested changes
Jul 26, 2017
techieshark
left a comment
techieshark
left a comment
Contributor
There was a problem hiding this comment.
See comments in review. I noticed a .least-text issue.
| <p class="disclaimer lesser-text">Information subject to change; by using this, you agree to our <a href="https://education.nsw.gov.au/going-to-a-public-school/finding-a-public-school/terms-of-use" target="_blank">terms of use</a>.</p> | ||
| </div> | ||
|
|
||
| <p class="disclaimer lesser-text"><a id="specialist-support-click" href="javascript:return false">Information for specialist support</a></p> |
Contributor
There was a problem hiding this comment.
I think if this isn't actually a link, it should be a , yeah?
See also:
|
|
||
| <p class="disclaimer lesser-text"><a id="specialist-support-click" href="javascript:return false">Information for specialist support</a></p> | ||
| <div id="specialist-support-info" style="display:none"> | ||
| <p class="disclaimer lesser-text least-text">The department provides a range of specialist support classes in regular and special schools. Access to these classes is through a separate placement panel process. Parents and carers wanting to enrol their child in a specialist support class should use the School Finder to locate their local public school and contact the principal directly. The principal will provide advice about the process to seek enrolment in a specialist support class.</p> |
Contributor
There was a problem hiding this comment.
What is the 'least-text' class? .lesser-text is defined here: https://github.com/CodeforAustralia/school-finder/blob/2388e6930b8fa43fc4b0f73356a589ed357ca0a9/css/style.css but I don't see least-text
Contributor
There was a problem hiding this comment.
I do like the content we're providing parents and principals here - it's specific and clear.
| <p class="disclaimer lesser-text"><a id="specialist-support-click" href="javascript:return false">Information for specialist support</a></p> | ||
| <div id="specialist-support-info" style="display:none"> | ||
| <p class="disclaimer lesser-text least-text">The department provides a range of specialist support classes in regular and special schools. Access to these classes is through a separate placement panel process. Parents and carers wanting to enrol their child in a specialist support class should use the School Finder to locate their local public school and contact the principal directly. The principal will provide advice about the process to seek enrolment in a specialist support class.</p> | ||
| <p class="disclaimer lesser-text least-text">Information about this process is available at <a href="https://education.nsw.gov.au/disability-learning-and-support/programs-and-services" target="_blank">Programs and Services</a>. For the current list of regular and special schools with specialist support classes, visit the <a href="https://data.cese.nsw.gov.au/data/dataset/specialist-support-classes-by-school-and-support-needs-type" target="_blank">Datahub.</a></p> |
Contributor
There was a problem hiding this comment.
Great plug for the Datahub!
More crlf griefs
# WARNING: head commit changed in the meantime
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.