fix: standardize on npm, remove yarn resolutions, regenerate lockfile#16
Merged
fix: standardize on npm, remove yarn resolutions, regenerate lockfile#16
Conversation
- Remove yarn-only 'resolutions' field (npm ignores it) - Update 'packageManager' from yarn@1.22.22 to npm@10 - Regenerate lockfile with npm to apply overrides correctly - Verified picomatch pinned to safe versions: - picomatch@4.0.4 (not vulnerable 4.0.0-4.0.3) - picomatch@2.3.2 (not vulnerable 2.3.0-2.3.1) - No picomatch@3.x present This ensures the workflow CI consistency and prevents picomatch ReDoS vulnerabilities from being reintroduced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the picomatch ReDoS vulnerability by standardizing on npm across CI and local development.
Changes
resolutionsfield from package.json (npm ignores it anyway)yarn@1.22.22tonpm@10overridescorrectlypicomatch@4.0.4✅ (not vulnerable 4.0.0-4.0.3)picomatch@2.3.2✅ (not vulnerable 2.3.0-2.3.1)picomatch@3.x❌Why This Matters
npm.ciin CI uses exactly what's in package-lock.jsonTesting
Run locally:
Verify output shows only safe versions and no vulnerable picomatch instances.
Fixes: Prevents reintroduction of picomatch ReDoS vulnerabilities