🐛 fix(ui): shrink table columns to fit and pin the group Update All button (#467)#468
Merged
Conversation
…utton (#467) The rc.4 v6→v7 preferences migration force-adds the new Version column (~220px) to every existing user's containers column set. The responsive auto-hide budget sums column *minimum* widths while the renderer laid columns out at their *preferred* widths and never shrank them, so in the band between those two sums the table overflowed horizontally and the group-header Update All button — a plain flex child of a full-row cell, unlike the sticky per-row Actions column — scrolled out of view. - 🐛 DataTable resolveColumnWidths() now shrinks columns proportionally toward (never below) minSize when the base widths overflow, so rendered widths agree with the auto-hide budget's fits decision - 🐛 the group-header Update All button is pinned to the visible end edge (sticky, logical props) so it stays reachable even when a table legitimately overflows between auto-hide steps - ✅ regression specs reproduce the exact rc.4 width band and pin the expansion path unchanged
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
biggest-littlest
approved these changes
Jul 2, 2026
biggest-littlest
left a comment
Member
There was a problem hiding this comment.
Shrink-to-minSize water-filling is the right class fix — render now agrees with the auto-hide budget, and the sticky pin covers the residual overflow band. Regression spec reproduces the reported width band exactly. LGTM.
ALARGECOMPANY
approved these changes
Jul 2, 2026
ALARGECOMPANY
left a comment
Member
There was a problem hiding this comment.
Verified the expansion path is pinned unchanged and coverage holds at 100%. CHANGELOG entry reads well. Approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #467 (v1.5.1-rc.4 regression, GA-blocking).
Root cause
The rc.4 v6→v7 preferences migration force-adds the new Version column (~220px) to every existing user's containers column set. The responsive auto-hide budget sums column minimum widths, but the renderer laid columns out at their preferred widths and never shrank them. In the band between those two sums (~1324–1544px of content width for the default column set) the table overflows horizontally, and the group-header Update All button — a plain flex child of a full-row
<td colspan>, unlike thesticky right-0per-row Actions cells — scrolls out of the visible area. Badge and row action icons stay visible, the button silently disappears. Root cause was established by a 5-agent triage workflow and upheld by two independent adversarial verifiers against the rc.3/rc.4 sources.Fix
DataTable.resolveColumnWidths()now shrinks columns proportionally toward (never below)minSizewhen base widths overflow the available width (water-filling with per-pass clamping). Rendered widths now agree with the auto-hide budget's minSize-based "fits" decision, eliminating the divergence band. Expansion behavior forextra > 0is unchanged and pinned by a hand-verified test.sticky end-0, logical props for RTL) so it stays reachable even when a table legitimately overflows between auto-hide steps.[1.5.1-rc.5]section added.Testing