Conversation
mankitkong
suggested changes
May 12, 2020
Contributor
mankitkong
left a comment
mankitkong
left a comment
There was a problem hiding this comment.
Good. This wouldnt work when the csv is too big, i.e. bigger than the maximum allowance of email messages + attachments. I think its around 25mb to 35mb. I am assuming it would quickly reach that number and all the emails will error out. What do you think could be the solution?
mankitkong
reviewed
May 13, 2020
Contributor
mankitkong
left a comment
mankitkong
left a comment
There was a problem hiding this comment.
Whats the .gitkeep for?
Contributor
Author
|
It's to add the metricData folder to git. If you don't want it there's a package that creates a directory instead. |
mankitkong
suggested changes
May 20, 2020
Contributor
mankitkong
left a comment
mankitkong
left a comment
There was a problem hiding this comment.
Change setTimeout to a node-cron job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generates a CSV file from PostgreSQL data and emails it to a given address.