AB#139412 AB#142911 - Address security vulnerabilities (yaml, ws, form-data, langsmith)#898
Open
fabclj wants to merge 2 commits into
Open
AB#139412 AB#142911 - Address security vulnerabilities (yaml, ws, form-data, langsmith)#898fabclj wants to merge 2 commits into
fabclj wants to merge 2 commits into
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
There was a problem hiding this comment.
Pull request overview
Pins the transitive yaml dependency to a non-vulnerable version for two npm-based extensions, addressing reported security advisories by forcing resolution to yaml@2.8.3 and regenerating lockfiles accordingly.
Changes:
- Added
overrides.yaml = 2.8.3toextensions/diffbot/package.jsonandextensions/chuck-norris-jokes/package.json. - Regenerated both
package-lock.jsonfiles sonode_modules/yamlresolves to2.8.3with updatedresolved/integritymetadata.
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| extensions/diffbot/package.json | Adds npm overrides to pin transitive yaml to 2.8.3. |
| extensions/diffbot/package-lock.json | Updates the resolved yaml package entry to 2.8.3. |
| extensions/chuck-norris-jokes/package.json | Adds npm overrides to pin transitive yaml to 2.8.3. |
| extensions/chuck-norris-jokes/package-lock.json | Updates the resolved yaml package entry to 2.8.3 (and lockfile metadata regenerated). |
Files not reviewed (2)
- extensions/chuck-norris-jokes/package-lock.json: Language not supported
- extensions/diffbot/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Additional dependency fixes on top of the yaml bump: - chuck-norris-jokes: ws 8.18.3 -> 8.21.0, form-data 4.0.4 -> 4.0.6 (in-range, lockfile only) - diffbot + chuck-norris-jokes: langsmith 0.3.65 -> 0.6.0 (override; forced past langchain's ^0.3.46 since no in-range fix exists, validated by transpile + diffbot test suite) Resolves the remaining HIGH-severity vulns (langsmith deserialization, ws amplification). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
fabclj
changed the title
fabclj
changed the title
vitaliigriaznov
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security dependency fixes for
extensions/diffbotandextensions/chuck-norris-jokes. Resolves all HIGH-severity Snyk findings in both extensions.yamloverrideslangsmithoverrideswsform-datawsandform-dataare within their declared ranges (^8.18.0/^4.0.0), so they update via the lockfile only.langsmithhas no in-range fix (langchain requires^0.3.46; all langsmith fixes are ≥0.4.6), so it is pinned via a forcedoverridesentry — see caveat below.How to test
cd extensions/diffbot && npm ci && snyk test→ no HIGH/critical (langsmith, yaml resolved).cd extensions/chuck-norris-jokes && npm ci && snyk test→ no HIGH/critical (langsmith, ws, form-data, yaml resolved).npm run buildin each → transpile/lint pass; diffbot test suite passes (6/6).Security / caveat
langsmith0.6.0 is forced past langchain's^0.3.46range (no in-range fix exists). Validated by transpile + diffbot's test suite (6/6 pass);langsmithis tracing/telemetry, so runtime risk is low. The fully in-range alternative would be upgradinglangchainitself (larger change). Flagging for reviewer awareness.js-yaml4.1.1 (medium) is intentionally left out — its fix (4.2.0) is a breaking minor and warrants separate review.