Issue 26#39
Open
youfoundron wants to merge 75 commits intomasterfrom
Open
Conversation
Member
|
So, I'm starting to think that we need to add a button now. I say this because ideally we should pre-select an account for the user, but since selecting an account is seen as "submit", we need to have a separate button with which to do this. The functional code itself looks good - but I'm going to leave this open and add a button, then I will merge this. |
Contributor
Author
|
Agreed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<datalist>element falls back to a regular<input/>in Safari so I need to work on a polyfill.It seems like there are several options but I hate to introduce dependencies...
@coopermaruyama Would you consider merging and making safari support a separate issue?