Bendered code review1

[bendered2332]

Description of the project:
This application is a great idea and reminds me a lot of IMDB.

• The README.md clearly outlines where this project will go and what the final build will look like.
• The project wasn't in the main branch when I pulled it down so I created the entire project.
• They also have a good JSON file for their data

Was the program available in UC Github on time?

• Yes, the project was available on Github in time. However, in the main branch, there was just a README.md file.

Is the program documented/commented well enough for you to understand?
The project was not commented on, but I could see where they were going with it based on their README.md. It looks as though their application is going to resemble the myPlantDiary structure pretty close.

Does the program compile?
Yes, the program compiles, however it was blank.

The rationale behind your changes.
The project didn't have any DTO or DAOpackages so I went ahead and created those. I also added a sample Movie DTO class based on the JSON file they have in their README.md. I also set up a theoretical DAO class but since they didn't have retrofit installed it wouldn't work properly.

Links to three specific commits that you made to your own group's GitHub repository before the end of the sprint deadline.

• b4c6005
• 2f9f26a
• 877a78b

If you do not post links to three commits that you made to your group's GitHub repo, your code review grade will be subject to a 20% penalty.

Next, list three specific technical concepts that you learned from this code review. Copy and paste samples to demonstrate your point.

• I learned how to add projects to an empty folder within Android Studio and getting them to compile. I needed to do this because the main branch only had the README.md file in it.
• I also learned how to read JSON data better and the proper titling for DTO class variables within Kotlin found here (https://kotlinlang.org/docs/coding-conventions.html#class-headers).
• Finally, I learned about the importance of having good JSON data to pull from. The data that this group has is very easy to understand and will make getting the information they need all the easier.

[discospiff]

Avoid pushing commented code to Version Control. Version control has tools that makes this unnecessary.

• You can look at history to see what used to be there.
• You can use branches for experimental features.

[discospiff]

Avoid pushing commented code to Version Control. Version control has tools that makes this unnecessary.

• You can look at history to see what used to be there.
• You can use branches for experimental features.

[discospiff]

It's hard to tell what changed in this branch, because all of the files are new. And, master only has a readme. Is this the correct branch for this project? I suspect maybe not... so merging would not add value.