Conversation
… activity_main xml
|
Analysis of the program: Overall, I made progress on the Interface side of the application.
Was the program available in UC Github on time: Is the program documented/commented well enough for you to understand: |
|
specific technical concepts : Learned setClickListener used for buttons |
|
Comments for this commit: Still trying to figure out the navigation bar and how to make it work properly. Kept getting errors when trying to implement it |
|
Comments for this commit: |
|
Comments for this commit: |
| // your code to perform when the user clicks on the button | ||
|
|
||
| result.text = "the $name was released in $year" | ||
|
|
||
|
|
||
| Toast.makeText(this@MainActivity, "You clicked me.", Toast.LENGTH_SHORT).show() |
There was a problem hiding this comment.
This looks like an incomplete feature.
Are you using these anywhere?
If not in use, remove them. Keep the codebase as small as possible to do the job you want to do. Unused code is clutter, and bad documentation, which increases technical debt.
Only complete features, which meet the team's Definition of Done, should be merged to Main/Master.
| package com.example.mymovieinfo.ui.theme | ||
| import androidx.compose.foundation.shape.RoundedCornerShape | ||
| import androidx.compose.material.Shapes | ||
| import androidx.compose.ui.unit.dp | ||
|
|
||
| val Shapes =Shapes( | ||
| small = RoundedCornerShape(4.dp), | ||
| medium = RoundedCornerShape(5.dp), | ||
| large = RoundedCornerShape(0.dp) | ||
| //add more shapes | ||
| ) No newline at end of file |
There was a problem hiding this comment.
It looks like this group is using XML layouts. If that's the case, Compose themes will not be used, and this can be discarded.
| val Silver100 = Color(0xFFF0FFFF) | ||
| //Figure out hex color values for various colors | ||
| //create theme file to use text type, color, and shape data |
There was a problem hiding this comment.
It looks like this group is using XML layouts. If that's the case, Compose themes will not be used, and this can be discarded.
| val Typography = Typography( | ||
| body1 = TextStyle( | ||
| fontFamily = FontFamily.SansSerif, | ||
| fontWeight = FontWeight.Normal, | ||
| fontSize = 16.sp | ||
| //add back up set of typography just in case |
There was a problem hiding this comment.
It looks like this group is using XML layouts. If that's the case, Compose themes will not be used, and this can be discarded.
|
I lean against merging this branch, as:
New functionality should be kept in a separate branch until it is complete and meets the team's Definition of Done. Thus, if the team would like these features, they can keep the branch open and continue to work on it, and then merge once it meets the Definition of Done. Otherwise, if they do not want these changes, they can abandon/delete this branch and not merge it. |
2 participants
This is my code review 2 due Tuesday