Conversation
| @@ -5,3 +5,4 @@ import androidx.compose.ui.graphics.Color | |||
| val Silver100 = Color(0xFFF0FFFF) | |||
| //Figure out hex color values for various colors | |||
| //create theme file to use text type, color, and shape data | |||
There was a problem hiding this comment.
Figure out hex color values for various colors
create theme file to use text type, color, and shape data before next code review
There was a problem hiding this comment.
Big no-no: do not put conversation in source code comments. That's clutter. Put the conversation here, in the Files Changed section of the pull request, where you can have a dialog with other developers.
| implementation 'androidx.appcompat:appcompat:1.4.1' | ||
| implementation 'com.google.android.material:material:1.5.0' | ||
| implementation 'androidx.constraintlayout:constraintlayout:2.1.3' | ||
| implementation 'androidx.compose.material:material:1.0.0-rc01' |
There was a problem hiding this comment.
Add dependence to gradle build
|
What I learned from this code review is that the SerializedName value should match JSON data feed. |
|
For the UI need to figure out if i'm using business logic or data access in the layers? |
|
Link of Commits: https://github.com/ColinMaxwell2001/MobileMovieApp/commits/Payton |
| <<<<<<< Updated upstream | ||
| ======= | ||
| import org.w3c.dom.Text | ||
| import java.io.IOException | ||
| import java.io.InputStream | ||
| >>>>>>> Stashed changes |
There was a problem hiding this comment.
Errrr... this is a merge conflict. This shouldn't be pushed to GitHub, as it breaks the build.
| fontWeight = FontWeight.Normal, | ||
| fontSize = 16.sp | ||
| //add back up set of typography just in case | ||
| ) |
There was a problem hiding this comment.
Big no-no: do not put conversation in source code comments. That's clutter. Put the conversation here, in the Files Changed section of the pull request, where you can have a dialog with other developers.
|
I wouldn't merge this branch, as it breaks the build. |
… activity_main xml
Commit 1 for code review 2.
2 participants
No description provided.