Add Time type support, update README type mapping (Issue #18)#19
Merged
Merged
Conversation
Add D1Time type processor for sqlalchemy.Time columns, preventing D1_TYPE_ERROR when inserting Python time objects. Update README type mapping table to document all custom type processors. Bump to v0.3.8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
D1Timetype processor forsqlalchemy.Timecolumns, preventingD1_TYPE_ERRORwhen inserting PythontimeobjectsD1Boolean,D1Date,D1Time,D1DateTime,D1LargeBinary)Test plan
TestTimeColumntests pass (insert/retrieve, nullable, ORM, filter)TestWorkerTimeColumntests pass (insert/retrieve, nullable, ORM)pre-commit run --all-filespassesCloses #18 (Time portion)