Add concurrency tests for parallel query execution (Issue #20)#21
Merged
Conversation
Proves that both create_engine_from_binding() and WorkerConnection support concurrent D1 queries via asyncio.gather(). Each test fires 10 unique parameterized queries sequentially then in parallel and asserts parallel time is < 80% of sequential time. Key finding: SyncWorkerConnection.run_sync() drives the JS event loop rather than blocking it, so asyncio.gather() genuinely interleaves D1 round-trips for both connection types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestParallelQueriesto the Worker integration test suite with two timing-based testscreate_engine_from_binding()andWorkerConnectionboth support concurrent D1 queries viaasyncio.gather()Key finding
SyncWorkerConnectionusespyodide.ffi.run_sync()internally, which drives the JS event loop rather than blocking it. This meansasyncio.gather()genuinely interleaves D1 round-trips — the user's concern in issue #20 is not a problem in practice.Test plan
test_engine_queries_are_concurrent—create_engine_from_binding()shows speedup withasyncio.gather()test_worker_connection_queries_are_concurrent—WorkerConnectionshows speedup withasyncio.gather()Closes #20