Skip to content

Reworking API for 1.0 and Java port#177

Open
HaloFour wants to merge 5 commits into
Comcast:masterfrom
HaloFour:rework-api
Open

Reworking API for 1.0 and Java port#177
HaloFour wants to merge 5 commits into
Comcast:masterfrom
HaloFour:rework-api

Conversation

@HaloFour

Copy link
Copy Markdown
Collaborator

No description provided.

@codecov-io

codecov-io commented Feb 19, 2021

Copy link
Copy Markdown

Codecov Report

Merging #177 (9e4cbc1) into master (15d23cd) will increase coverage by 0.04%.
The diff coverage is 89.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #177      +/-   ##
==========================================
+ Coverage   93.90%   93.94%   +0.04%     
==========================================
  Files          93       92       -1     
  Lines        1247     1190      -57     
  Branches       83       82       -1     
==========================================
- Hits         1171     1118      -53     
+ Misses         76       72       -4     
Impacted Files Coverage Δ
...src/main/scala/com/comcast/money/core/Tracer.scala 100.00% <ø> (ø)
.../scala/com/comcast/money/core/UnrecordedSpan.scala 12.50% <0.00%> (-1.79%) ⬇️
...la/com/comcast/money/otel/handlers/MoneyLink.scala 100.00% <ø> (ø)
...st/money/otel/handlers/MoneyReadableSpanData.scala 96.42% <ø> (ø)
.../scala/com/comcast/money/wire/SpanConverters.scala 86.95% <50.00%> (-1.81%) ⬇️
...c/main/scala/com/comcast/money/core/CoreSpan.scala 97.36% <100.00%> (+1.71%) ⬆️
...scala/com/comcast/money/core/CoreSpanBuilder.scala 100.00% <100.00%> (+5.88%) ⬆️
...scala/com/comcast/money/core/CoreSpanFactory.scala 100.00% <100.00%> (ø)
...a/com/comcast/money/core/MoneyTracerProvider.scala 83.33% <100.00%> (-4.17%) ⬇️
...la/com/comcast/money/core/internal/SpanLocal.scala 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15d23cd...9e4cbc1. Read the comment docs.

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 89.74359% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.94%. Comparing base (15d23cd) to head (9e4cbc1).
⚠️ Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
.../scala/com/comcast/money/core/UnrecordedSpan.scala 0.00% 2 Missing ⚠️
.../scala/com/comcast/money/wire/SpanConverters.scala 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #177      +/-   ##
==========================================
+ Coverage   93.90%   93.94%   +0.04%     
==========================================
  Files          93       92       -1     
  Lines        1247     1190      -57     
  Branches       83       82       -1     
==========================================
- Hits         1171     1118      -53     
+ Misses         76       72       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants