Skip to content

Range selection#2865

Open
hadyelzayady wants to merge 3 commits into
Comcast:mainfrom
hadyelzayady:range-selection
Open

Range selection#2865
hadyelzayady wants to merge 3 commits into
Comcast:mainfrom
hadyelzayady:range-selection

Conversation

@hadyelzayady

@hadyelzayady hadyelzayady commented Mar 26, 2022

Copy link
Copy Markdown
Contributor

Range selection with a mouse or shift+arrows.
copy and paste are handled.
group rows are not handled.
auto-scroll on range selection will be handled soon

Screen.Recording.2022-03-26.at.11.19.41.AM.mov

#2753 #2260

@babakansari

Copy link
Copy Markdown

Hi @hadyelzayady,

Any ballpark when could this feature become available for public use? Thanks!

cc @amanmahajan7 , @nstepien

@farooq7124

Copy link
Copy Markdown

Hi @amanmahajan7

Request you to please review this feature and make it available for users

Thanks

@adityatoshniwal

Copy link
Copy Markdown

HI @hadyelzayady,

An improvement could be - When using shift + arrow on row selection checkbox, it will change the selection of complete row and not just the row selection box.

@jmjuanico

Copy link
Copy Markdown

@hadyelzayady @amanmahajan7 looking forward to have this available. thanks.

@ecoant

ecoant commented Oct 3, 2022

Copy link
Copy Markdown

Is anyone maintaining this project concerned with bringing this PR in? Would be really great to have the same features we already had in v5, I assumed upgrading would bring me an improved experience, not one where a major feature of excel-like data grids was dropped. @nstepien @amanmahajan7

@damnitrahul

Copy link
Copy Markdown

Hey @nstepien @amanmahajan7

Request you to please review this and consider merging it.

@damnitrahul

Copy link
Copy Markdown

Hey, @nstepien @amanmahajan7
Any thoughts on merging this?

@DVGY

DVGY commented Jul 2, 2023

Copy link
Copy Markdown

Need this feature ASAP

@pikpok

pikpok commented Sep 6, 2023

Copy link
Copy Markdown

@hadyelzayady I've rebased your PR on top of current main and modified it to allow selection of multiple ranges. It's hacky, but works good enough for my usecase. It's available here, and released as @pikpok/react-data-grid.
If you don't have anything against it and don't want to take care of this topic anymore, I can try to make it into a better state and submit a new PR. I see that there's some interest in getting this feature merged 🙂

@hadyelzayady

Copy link
Copy Markdown
Contributor Author

@pikpok That is fine, I lost interest anyway despite having other features in my mind back then

@DVGY

DVGY commented Sep 7, 2023

Copy link
Copy Markdown

@pikpok That is fine, I lost interest anyway despite having other features in my mind back then

Lol.

adamerose added a commit to adamerose/jsgrids that referenced this pull request Sep 15, 2023
statico pushed a commit to statico/awesome-javascript-grids that referenced this pull request Oct 9, 2023
@IrakliJani

IrakliJani commented Mar 30, 2024

Copy link
Copy Markdown

@holaChaitanya

Copy link
Copy Markdown

Hey, @nstepien @amanmahajan7
Any thoughts on merging this?

@sayers

sayers commented Jul 3, 2024

Copy link
Copy Markdown

@pikpok would you mind tidying up your fork and getting a PR up for multi select? Lots of people want this feature.

@adityatoshniwal

Copy link
Copy Markdown

We forked rdg and applied this PR (with some required changes) to use for pgAdmin here - https://github.com/pgadmin-org/react-data-grid. The latest commit is adding the range selection.

@s-elmer

s-elmer commented Mar 14, 2025

Copy link
Copy Markdown

Seems like this PR has been approved, is there any reason this feature hasn't been merged in? I think many users would love to have it

@hadyelzayady hadyelzayady reopened this Jul 6, 2025
@DVGY

DVGY commented Jul 7, 2025

Copy link
Copy Markdown

Hi Admin any timeline on this ?

@Nishant-supsync

Nishant-supsync commented Jul 16, 2025

Copy link
Copy Markdown

@amanmahajan7 @nstepien Is this PR being reviewed, i believe it's a very useful thing that's needed.
Sad thing that this PR is sitting here since 2 years, shows how careless the admins are for this

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@edikurniawan-dev

Copy link
Copy Markdown

@amanmahajan7 @nstepien
This PR is sitting here since 2 years, shows how careless the admins are for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.