Skip to content

feat(api-nodes): update xAI Grok nodes#13140

Merged
Kosinkadink merged 1 commit intomasterfrom
feat/api-nodes/grok-update
Mar 24, 2026
Merged

feat(api-nodes): update xAI Grok nodes#13140
Kosinkadink merged 1 commit intomasterfrom
feat/api-nodes/grok-update

Conversation

@bigcat88
Copy link
Copy Markdown
Contributor

@bigcat88 bigcat88 commented Mar 24, 2026

API Node PR Checklist

Scope

  • Is API Node Change

Pricing & Billing

  • Need pricing update
  • No pricing update

If Need pricing update:

  • Metronome rate cards updated
  • Auto‑billing tests updated and passing

QA

  • QA done
  • QA not required

Comms

  • Informed Kosinkadink

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 24, 2026

📝 Walkthrough

Walkthrough

This pull request introduces two new Grok video API nodes to the node catalog: GrokVideoReferenceNode and GrokVideoExtendNode. The reference node accepts a prompt with up to 7 reference images along with generation parameters, while the extend node accepts a prompt and input video with validation constraints. Both nodes support uploads to the Grok API and utilize a new pricing extraction function. Additionally, the existing GrokVideoNode has been updated to normalize the model name from "grok-imagine-video-beta" to "grok-imagine-video" before submission. The new nodes are registered in the node catalog for availability.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'feat(api-nodes): update xAI Grok nodes' directly relates to the main changes, which add new Grok video nodes and update existing ones with new functionality.
Description check ✅ Passed The description references the PR checklist covering API node changes, pricing updates, QA, and team communication, which are all relevant to this pull request's scope.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@comfy_api_nodes/nodes_grok.py`:
- Around line 694-702: The VideoExtensionRequest currently omits the chosen
model value from model["model"], causing inconsistency with other video nodes;
update the call that constructs VideoExtensionRequest (in the sync_op call using
upload_video_to_comfyapi and VideoExtensionRequest) to include
model=model["model"] when building the request object (or if the extension
endpoint truly doesn't accept a model, remove the DynamicCombo that supplies
model["model"]), ensuring the request usage matches
GrokVideoEditNode/GrokVideoReferenceNode patterns.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 656a4f90-fb50-4248-8735-756870e9662e

📥 Commits

Reviewing files that changed from the base of the PR and between 2d5fd3f and 7b43a5e.

⛔ Files ignored due to path filters (1)
  • comfy_api_nodes/apis/grok.py is excluded by !comfy_api_nodes/apis/**
📒 Files selected for processing (1)
  • comfy_api_nodes/nodes_grok.py

@Kosinkadink Kosinkadink merged commit f9ec85f into master Mar 24, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants