[API Nodes] add new nodes for WAN2.7#13264
Conversation
Signed-off-by: bigcat88 <bigcat88@icloud.com>
📝 WalkthroughWalkthroughThe pull request refactors 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
comfy_api_nodes/nodes_wan.py (1)
1256-1267: Remove unusedpromptandnegative_promptparameters.These parameters are never used in the method body—the actual values are retrieved from
model["prompt"]andmodel["negative_prompt"](lines 1292-1293). Other WAN 2.7 nodes don't have these top-level parameters.♻️ Suggested fix
`@classmethod` async def execute( cls, model: dict, first_clip: Input.Video, - prompt: str = "", - negative_prompt: str = "", last_frame: Input.Image | None = None, seed: int = 0, prompt_extend: bool = True, watermark: bool = False, ):🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@comfy_api_nodes/nodes_wan.py` around lines 1256 - 1267, The execute method on the WAN node class has unused top-level parameters prompt and negative_prompt; remove these parameters from the async def execute(...) signature so the method relies only on model["prompt"] and model["negative_prompt"] (leave the lines that read model["prompt"] and model["negative_prompt"] intact). Update the function signature in the class method (remove prompt: str = "" and negative_prompt: str = ""), and adjust any call sites/tests that pass those positional/keyword args to now omit them; ensure imports/type hints still validate after the signature change.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@comfy_api_nodes/nodes_wan.py`:
- Around line 1256-1267: The execute method on the WAN node class has unused
top-level parameters prompt and negative_prompt; remove these parameters from
the async def execute(...) signature so the method relies only on
model["prompt"] and model["negative_prompt"] (leave the lines that read
model["prompt"] and model["negative_prompt"] intact). Update the function
signature in the class method (remove prompt: str = "" and negative_prompt: str
= ""), and adjust any call sites/tests that pass those positional/keyword args
to now omit them; ensure imports/type hints still validate after the signature
change.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: fd482071-b10d-4e8f-bda0-133c026ab2d0
⛔ Files ignored due to path filters (1)
comfy_api_nodes/apis/wan.pyis excluded by!comfy_api_nodes/apis/**
📒 Files selected for processing (1)
comfy_api_nodes/nodes_wan.py
Signed-off-by: bigcat88 <bigcat88@icloud.com>
API Node PR Checklist
Scope
Pricing & Billing
If Need pricing update:
QA
Comms