Skip to content

Add show_version_updates CLI feature flag#14646

Open
Kosinkadink wants to merge 2 commits into
masterfrom
feature/show-version-updates-flag
Open

Add show_version_updates CLI feature flag#14646
Kosinkadink wants to merge 2 commits into
masterfrom
feature/show-version-updates-flag

Conversation

@Kosinkadink

@Kosinkadink Kosinkadink commented Jun 26, 2026

Copy link
Copy Markdown
Member

Registers a show_version_updates bool feature flag (default false) in CLI_FEATURE_FLAG_REGISTRY.

This lets a launcher discover the flag via --list-feature-flags and set it via --feature-flag show_version_updates=<bool>, which propagates into SERVER_FEATURE_FLAGS and is sent to the frontend. The frontend uses it to seed the default of its Comfy.Notification.ShowVersionUpdates setting (the user setting still overrides).

Default false: a plain ComfyUI run advertises the flag as off, so the frontend's in-app new-release / version-update notifications stay off by default on local installs. A launcher (or --feature-flag show_version_updates=true) can turn them on.

Part of a 3-repo change for Comfy-Org/Comfy-Desktop#1194:

Registers a show_version_updates bool flag (default true) in CLI_FEATURE_FLAG_REGISTRY so launchers can override the frontend default for new-release/version-update notifications via --feature-flag.

Amp-Thread-ID: https://ampcode.com/threads/T-019f0347-dc00-723a-a4d2-558539329035
Co-authored-by: Amp <amp@ampcode.com>
@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

CLI_FEATURE_FLAG_REGISTRY in comfy_api/feature_flags.py now includes a new boolean flag named show_version_updates. The entry sets the default to False and adds description text indicating it controls frontend new-release/version-update notifications, while still allowing the user setting to override it.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: adding the show_version_updates CLI feature flag.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The description directly matches the change: adding the show_version_updates feature flag to the CLI registry.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant