fix: show file extensions in workflow sidebar#10833
Draft
dante01yoon wants to merge 1 commit intomainfrom
Draft
Conversation
Use node.key to derive leaf labels instead of node.label, which loses the file extension after PrimeVue Tree processing. Remove unused getFilenameDetails import. Fixes #10409
Contributor
📝 WalkthroughWalkthroughChanges restore file extension visibility in the workflow sidebar tree view. The leaf label computation was modified to extract the full filename from the node's key path rather than processing the label, effectively fixing the missing extension display. A corresponding test validates the preservation of filename extensions. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
Caution Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional.
❌ Failed checks (1 error)
✅ Passed checks (6 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎨 Storybook: ✅ Built — View Storybook |
🎭 Playwright: ❌ 907 passed, 15 failed · 4 flaky❌ Failed Tests📊 Browser Reports
|
📦 Bundle: 5.11 MB gzip 🔴 +73 BDetailsSummary
Category Glance App Entry Points — 22.3 kB (baseline 22.3 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.2 MB (baseline 1.2 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 76.6 kB (baseline 76.6 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed / 2 unchanged Panels & Settings — 484 kB (baseline 484 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 12 unchanged User & Accounts — 17.1 kB (baseline 17.1 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 5 added / 5 removed / 2 unchanged Editors & Dialogs — 109 kB (baseline 109 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 2 added / 2 removed UI Components — 60.3 kB (baseline 60.3 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed / 8 unchanged Data & Services — 2.97 MB (baseline 2.97 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 4 unchanged Utilities & Hooks — 338 kB (baseline 338 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 13 added / 13 removed / 13 unchanged Vendor & Third-Party — 9.8 MB (baseline 9.8 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 8.44 MB (baseline 8.44 MB) • ⚪ 0 BBundles that do not match a named category
Status: 55 added / 55 removed / 79 unchanged ⚡ Performance Report
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-04-03T01:11:05.342Z",
"gitSha": "4ab3d248956b7b893da2d38c9140e9309e15da5f",
"branch": "fix/workflow-sidebar-file-extensions",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2027.1119999999883,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.314,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 385.17400000000004,
"heapDeltaBytes": 21032676,
"heapUsedBytes": 65083396,
"domNodes": 20,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 26.712,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2048.9539999999806,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.226,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.36300000000006,
"heapDeltaBytes": 20430672,
"heapUsedBytes": 62881888,
"domNodes": 22,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 30.362000000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2011.2229999999727,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.369,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 420.149,
"heapDeltaBytes": -4571148,
"heapUsedBytes": 44263476,
"domNodes": 22,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 29.119,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1946.7630000000327,
"styleRecalcs": 79,
"styleRecalcDurationMs": 49.04399999999999,
"layouts": 12,
"layoutDurationMs": 3.8590000000000004,
"taskDurationMs": 881.0419999999999,
"heapDeltaBytes": 16062408,
"heapUsedBytes": 59118716,
"domNodes": 63,
"jsHeapTotalBytes": 23855104,
"scriptDurationMs": 146.73,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2035.5559999999855,
"styleRecalcs": 85,
"styleRecalcDurationMs": 46.968,
"layouts": 12,
"layoutDurationMs": 3.3330000000000006,
"taskDurationMs": 1024.643,
"heapDeltaBytes": 16767032,
"heapUsedBytes": 59146904,
"domNodes": 69,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 143.53700000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2032.7570000000605,
"styleRecalcs": 86,
"styleRecalcDurationMs": 46.648,
"layouts": 12,
"layoutDurationMs": 3.4920000000000004,
"taskDurationMs": 1028.103,
"heapDeltaBytes": 16761924,
"heapUsedBytes": 59260484,
"domNodes": 68,
"jsHeapTotalBytes": 23330816,
"scriptDurationMs": 138.465,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1753.7430000000427,
"styleRecalcs": 32,
"styleRecalcDurationMs": 20.833000000000002,
"layouts": 6,
"layoutDurationMs": 0.6560000000000001,
"taskDurationMs": 373.64699999999993,
"heapDeltaBytes": 24697384,
"heapUsedBytes": 67475964,
"domNodes": 80,
"jsHeapTotalBytes": 21233664,
"scriptDurationMs": 33.83899999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1751.7050000000154,
"styleRecalcs": 31,
"styleRecalcDurationMs": 19.342,
"layouts": 6,
"layoutDurationMs": 0.685,
"taskDurationMs": 334.77000000000004,
"heapDeltaBytes": 24748532,
"heapUsedBytes": 67229632,
"domNodes": 80,
"jsHeapTotalBytes": 20447232,
"scriptDurationMs": 30.399999999999995,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.659999999999975,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1757.178999999951,
"styleRecalcs": 32,
"styleRecalcDurationMs": 20.031000000000002,
"layouts": 6,
"layoutDurationMs": 0.75,
"taskDurationMs": 349.584,
"heapDeltaBytes": 24696068,
"heapUsedBytes": 67269068,
"domNodes": 79,
"jsHeapTotalBytes": 20185088,
"scriptDurationMs": 31.938999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 600.7849999999735,
"styleRecalcs": 12,
"styleRecalcDurationMs": 10.646,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 380.8,
"heapDeltaBytes": 7636940,
"heapUsedBytes": 50403156,
"domNodes": 20,
"jsHeapTotalBytes": 13107200,
"scriptDurationMs": 73.796,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 581.3420000000065,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.061,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 364.047,
"heapDeltaBytes": 6720820,
"heapUsedBytes": 49231772,
"domNodes": 22,
"jsHeapTotalBytes": 12845056,
"scriptDurationMs": 68.15400000000001,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 577.9599999999618,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.522,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 361.283,
"heapDeltaBytes": 6464692,
"heapUsedBytes": 49303432,
"domNodes": 22,
"jsHeapTotalBytes": 13369344,
"scriptDurationMs": 68.875,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-idle",
"durationMs": 2062.591999999995,
"styleRecalcs": 11,
"styleRecalcDurationMs": 12.686,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 684.459,
"heapDeltaBytes": 16747600,
"heapUsedBytes": 68475068,
"domNodes": -255,
"jsHeapTotalBytes": 15454208,
"scriptDurationMs": 131.121,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2048.379999999952,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.413999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 577.544,
"heapDeltaBytes": 4964232,
"heapUsedBytes": 55905348,
"domNodes": -262,
"jsHeapTotalBytes": 16707584,
"scriptDurationMs": 114.02100000000002,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2013.2190000000492,
"styleRecalcs": 10,
"styleRecalcDurationMs": 11.059000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 608.496,
"heapDeltaBytes": 508148,
"heapUsedBytes": 51132576,
"domNodes": -257,
"jsHeapTotalBytes": 15396864,
"scriptDurationMs": 111.65499999999997,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2173.8600000000474,
"styleRecalcs": 70,
"styleRecalcDurationMs": 18.039,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1199.318,
"heapDeltaBytes": 18121672,
"heapUsedBytes": 71456508,
"domNodes": -258,
"jsHeapTotalBytes": 18747392,
"scriptDurationMs": 444.63399999999996,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2139.5430000000033,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.947000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1114.328,
"heapDeltaBytes": 18295100,
"heapUsedBytes": 71422268,
"domNodes": -264,
"jsHeapTotalBytes": 18747392,
"scriptDurationMs": 393.243,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2163.770999999997,
"styleRecalcs": 69,
"styleRecalcDurationMs": 16.065,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1224.124,
"heapDeltaBytes": 14375596,
"heapUsedBytes": 66389916,
"domNodes": -260,
"jsHeapTotalBytes": 19009536,
"scriptDurationMs": 452.184,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3209.8890000000324,
"styleRecalcs": 66,
"styleRecalcDurationMs": 18.426,
"layouts": 60,
"layoutDurationMs": 7.614000000000001,
"taskDurationMs": 1412.919,
"heapDeltaBytes": 7811184,
"heapUsedBytes": 62324148,
"domNodes": -264,
"jsHeapTotalBytes": 17756160,
"scriptDurationMs": 526.341,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3193.3479999999577,
"styleRecalcs": 66,
"styleRecalcDurationMs": 18.530000000000005,
"layouts": 60,
"layoutDurationMs": 7.704000000000001,
"taskDurationMs": 1422.8860000000002,
"heapDeltaBytes": 8350764,
"heapUsedBytes": 62879568,
"domNodes": -264,
"jsHeapTotalBytes": 17231872,
"scriptDurationMs": 534.286,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3191.565999999966,
"styleRecalcs": 67,
"styleRecalcDurationMs": 18.579,
"layouts": 60,
"layoutDurationMs": 7.641,
"taskDurationMs": 1372.598,
"heapDeltaBytes": 7447744,
"heapUsedBytes": 62035680,
"domNodes": -264,
"jsHeapTotalBytes": 18018304,
"scriptDurationMs": 508.4780000000001,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2041.1579999999958,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.577000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 645.2370000000001,
"heapDeltaBytes": 4739748,
"heapUsedBytes": 56867908,
"domNodes": -260,
"jsHeapTotalBytes": 15396864,
"scriptDurationMs": 118.206,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2070.720999999935,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.296,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 610.938,
"heapDeltaBytes": 4617240,
"heapUsedBytes": 56825036,
"domNodes": -259,
"jsHeapTotalBytes": 15921152,
"scriptDurationMs": 116.24200000000002,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2010.1600000000417,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.747000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 591.558,
"heapDeltaBytes": 2298152,
"heapUsedBytes": 55634144,
"domNodes": -264,
"jsHeapTotalBytes": 16183296,
"scriptDurationMs": 104.67299999999999,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 601.7540000000281,
"styleRecalcs": 48,
"styleRecalcDurationMs": 13.215000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.695,
"heapDeltaBytes": 6200588,
"heapUsedBytes": 49256500,
"domNodes": 22,
"jsHeapTotalBytes": 13631488,
"scriptDurationMs": 134.768,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 561.172000000056,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.683999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 369.794,
"heapDeltaBytes": 6287244,
"heapUsedBytes": 49300968,
"domNodes": 21,
"jsHeapTotalBytes": 13369344,
"scriptDurationMs": 130.114,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 553.0129999999644,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.626,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 364.18000000000006,
"heapDeltaBytes": 6165880,
"heapUsedBytes": 49231700,
"domNodes": 20,
"jsHeapTotalBytes": 13369344,
"scriptDurationMs": 126.173,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2022.0649999999978,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.021,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 412.62600000000003,
"heapDeltaBytes": 19892388,
"heapUsedBytes": 63108356,
"domNodes": 20,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 27.438999999999997,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2026.9660000000158,
"styleRecalcs": 11,
"styleRecalcDurationMs": 14.437,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 391.935,
"heapDeltaBytes": 20153492,
"heapUsedBytes": 63278888,
"domNodes": 22,
"jsHeapTotalBytes": 22282240,
"scriptDurationMs": 21.682,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2017.6069999999982,
"styleRecalcs": 10,
"styleRecalcDurationMs": 14.585,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 419.7270000000001,
"heapDeltaBytes": 20164148,
"heapUsedBytes": 63420000,
"domNodes": 20,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 25.863,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1973.3130000000187,
"styleRecalcs": 84,
"styleRecalcDurationMs": 48.635999999999996,
"layouts": 16,
"layoutDurationMs": 4.665,
"taskDurationMs": 968.9570000000001,
"heapDeltaBytes": 12630024,
"heapUsedBytes": 55359608,
"domNodes": 74,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 110.706,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1986.0830000000078,
"styleRecalcs": 86,
"styleRecalcDurationMs": 47.51499999999999,
"layouts": 16,
"layoutDurationMs": 4.731000000000001,
"taskDurationMs": 934.758,
"heapDeltaBytes": 11902648,
"heapUsedBytes": 54938644,
"domNodes": 72,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 105.021,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1688.886000000025,
"styleRecalcs": 76,
"styleRecalcDurationMs": 39.068000000000005,
"layouts": 16,
"layoutDurationMs": 4.639,
"taskDurationMs": 686.937,
"heapDeltaBytes": 11627632,
"heapUsedBytes": 54422332,
"domNodes": 63,
"jsHeapTotalBytes": 23330816,
"scriptDurationMs": 103.394,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "viewport-pan-sweep",
"durationMs": 8251.695999999982,
"styleRecalcs": 251,
"styleRecalcDurationMs": 46.111000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4305.505,
"heapDeltaBytes": 33581304,
"heapUsedBytes": 83999896,
"domNodes": -255,
"jsHeapTotalBytes": 26611712,
"scriptDurationMs": 1548.7849999999999,
"eventListeners": -107,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8177.628999999968,
"styleRecalcs": 252,
"styleRecalcDurationMs": 45.545,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3848.3569999999995,
"heapDeltaBytes": 26013396,
"heapUsedBytes": 76551656,
"domNodes": -257,
"jsHeapTotalBytes": 19009536,
"scriptDurationMs": 1299.45,
"eventListeners": -111,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8156.463000000031,
"styleRecalcs": 252,
"styleRecalcDurationMs": 45.269000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3788.1220000000003,
"heapDeltaBytes": 25530188,
"heapUsedBytes": 76090716,
"domNodes": -256,
"jsHeapTotalBytes": 19271680,
"scriptDurationMs": 1268.893,
"eventListeners": -111,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12531.529999999975,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12520.064,
"heapDeltaBytes": -30823600,
"heapUsedBytes": 165792440,
"domNodes": -8331,
"jsHeapTotalBytes": 27877376,
"scriptDurationMs": 588.052,
"eventListeners": -16462,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12674.396999999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12659.927,
"heapDeltaBytes": -46082956,
"heapUsedBytes": 162281084,
"domNodes": -8331,
"jsHeapTotalBytes": 23945216,
"scriptDurationMs": 623.345,
"eventListeners": -16462,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12516.712999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12504.653999999999,
"heapDeltaBytes": -30850456,
"heapUsedBytes": 166678660,
"domNodes": -8331,
"jsHeapTotalBytes": 27353088,
"scriptDurationMs": 606.268,
"eventListeners": -16462,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14742.122999999992,
"styleRecalcs": 67,
"styleRecalcDurationMs": 15.466999999999981,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14705.841,
"heapDeltaBytes": -62002772,
"heapUsedBytes": 148394392,
"domNodes": -8331,
"jsHeapTotalBytes": -958464,
"scriptDurationMs": 1004.319,
"eventListeners": -16488,
"totalBlockingTimeMs": 74,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14342.903999999977,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.336999999999989,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14320.751000000002,
"heapDeltaBytes": -22522768,
"heapUsedBytes": 173609824,
"domNodes": -8333,
"jsHeapTotalBytes": 25432064,
"scriptDurationMs": 867.1819999999999,
"eventListeners": -16462,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 14529.801999999905,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.998000000000012,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14501.955999999998,
"heapDeltaBytes": -6612068,
"heapUsedBytes": 187144584,
"domNodes": -8331,
"jsHeapTotalBytes": 25694208,
"scriptDurationMs": 951.408,
"eventListeners": -16460,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 454.93099999998776,
"styleRecalcs": 22,
"styleRecalcDurationMs": 29.059,
"layouts": 6,
"layoutDurationMs": 1.8499999999999999,
"taskDurationMs": 140.29400000000004,
"heapDeltaBytes": 4838000,
"heapUsedBytes": 49009432,
"domNodes": 191,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 32.093999999999994,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 452.158000000054,
"styleRecalcs": 16,
"styleRecalcDurationMs": 21.565,
"layouts": 5,
"layoutDurationMs": 1.3449999999999998,
"taskDurationMs": 122.20599999999997,
"heapDeltaBytes": 4511952,
"heapUsedBytes": 48921692,
"domNodes": 156,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 30.593000000000004,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 452.22499999999854,
"styleRecalcs": 19,
"styleRecalcDurationMs": 24.937,
"layouts": 5,
"layoutDurationMs": 1.2429999999999997,
"taskDurationMs": 124.427,
"heapDeltaBytes": 4515288,
"heapUsedBytes": 48773204,
"domNodes": 157,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 29.877000000000006,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
} |
QA 🔍 FocusedRun: https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/23929150579 · Download artifacts · All videos Video Reviewlinux QA Video Report
AI ReviewSummaryThe PR aims to ensure that file extensions (like Evaluation:
Behavior Changes
Timeline Comparison
Confirmed IssuesNone observed, as the relevant UI component was not shown. Possible Issues (Needs Human Verification)Missing Visual Verification of Fix
Overall RiskThe PR risk is low because it primarily involves a string manipulation change for UI labels and is backed by a unit test ( VerdictThe videos provided do not demonstrate the behavior described in the PR. The "Workflows" sidebar remains closed in both recordings. {"verdict": "INCONCLUSIVE", "risk": "low", "confidence": "high"} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Workflow sidebar now displays file extensions (.json, .app.json) instead of stripping them
Uses
node.keyto derive leaf labels, bypassing PrimeVue Tree's label mutationRemoves unused
getFilenameDetailsimportFixes Workflow Sidebar Menu no longer shows file extensions. #10409
Test plan
treeUtil.test.ts) verifying key-based label extraction preserves extensions.jsonsuffix┆Issue is synchronized with this Notion page by Unito