Add support for WoA#82
Conversation
|
Warning Review limit reached
Next review available in: 35 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PR adds Windows ARM CUDA wheel build and test jobs using CUDA 13.4 preview, configures ARM-specific CUDA compilation, publishes the resulting abi3 artifact, and adds ignore rules for hidden files and directories. ChangesWindows ARM CUDA wheels
Repository ignore rules
Sequence Diagram(s)sequenceDiagram
participant Build as build_wheels_windows_arm
participant CUDA as CUDA 13.4 installer
participant Config as setup.py and CMakeLists.txt
participant Test as test_windows_arm
participant Publish as publish
Build->>CUDA: Install and verify nvcc/cicc
Build->>Config: Build cp312-abi3 wheel with COMFY_CUDA_ARCHS=120f
Build->>Test: Upload wheels-windows-arm-cuda
Test->>Test: Install wheel, run ruff, and execute pytest
Test->>Publish: Satisfy publish prerequisites
Publish->>Publish: Download ARM CUDA wheel into dist/
Suggested reviewers: 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/build-wheels.yml:
- Around line 494-496: Add an explicit timeout-minutes setting to the
build_wheels_windows_arm job, choosing a reasonable limit for the full CUDA
build while preventing it from running up to the default six-hour workflow
limit. Keep the existing runner and build configuration unchanged.
In @.gitignore:
- Around line 20-21: Update the .gitignore patterns to stop broadly ignoring all
dot-prefixed files and directories. Remove the redundant blanket entries and
replace them with narrowly scoped rules for only generated hidden paths, while
explicitly allowing required repository directories such as .github and other
project configuration paths.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 4efbb653-ff6f-40d9-8837-4e06a18f9504
📒 Files selected for processing (4)
.github/workflows/build-wheels.yml.gitignorecomfy_kitchen/backends/cuda/CMakeLists.txtsetup.py
| build_wheels_windows_arm: | ||
| name: Build Windows ARM abi3 wheel | ||
| runs-on: windows-11-arm |
There was a problem hiding this comment.
🩺 Stability & Availability | 🔵 Trivial | ⚡ Quick win
Add timeout-minutes to the ARM build job. A full CUDA build (CuTe/CUTLASS) on a 4-core windows-11-arm runner, preceded by a preview-installer run, is a prime candidate to stall. Without an explicit timeout it can idle until the 6-hour default, burning minutes for naught.
⏱️ Suggested addition
build_wheels_windows_arm:
name: Build Windows ARM abi3 wheel
runs-on: windows-11-arm
+ timeout-minutes: 120📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| build_wheels_windows_arm: | |
| name: Build Windows ARM abi3 wheel | |
| runs-on: windows-11-arm | |
| build_wheels_windows_arm: | |
| name: Build Windows ARM abi3 wheel | |
| runs-on: windows-11-arm | |
| timeout-minutes: 120 |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.github/workflows/build-wheels.yml around lines 494 - 496, Add an explicit
timeout-minutes setting to the build_wheels_windows_arm job, choosing a
reasonable limit for the full CUDA build while preventing it from running up to
the default six-hour workflow limit. Keep the existing runner and build
configuration unchanged.
2 participants
CTK 13.4 added WoA support , adding CI in preparation of RTX Spark