Conversation
huchenlei
left a comment
huchenlei
left a comment
There was a problem hiding this comment.
Please link the frontend change in the PR description. Thanks!
| try { | ||
| const result = await todesktop.autoUpdater?.checkForUpdates(); | ||
| if (result?.updateInfo) { | ||
| log.info('Update found:', result.updateInfo.version); |
There was a problem hiding this comment.
Let's split this function into following 2 functions:
checkForUpdates: Check for update and returns the update infoupdateToLatest: Actually restart and do the update
| SHOW_DIRECTORY_PICKER: 'show-directory-picker', | ||
| INSTALL_COMFYUI: 'install-comfyui', | ||
| SHOW_CONTEXT_MENU: 'show-context-menu', | ||
| GET_OS_PLATFORM: 'get-os-platform', |
There was a problem hiding this comment.
Why do we need the OS_PLATFORM in electron API?
There was a problem hiding this comment.
Per specification the menu item should show only if the application is ran on Win32 platform so I need to way to determine that in frontend.
There was a problem hiding this comment.
We have a duplicate here - one sec.
Edit: See commit here - you can just call process.platform. No need for IPC, it just needs to be node.js not web app.
@huchenlei My req. was hiding e.g. Apple MPS as an option on Windows.
There was a problem hiding this comment.
Can we have the getOS API added in a separate PR?
Test Evidence CheckIf this PR modifies behavior that requires testing, a test explanation is required. PRs lacking applicable test explanations may not be reviewed until added. Please add test explanations to ensure code quality and prevent regressions. If this PR changes user-facing behavior, visual proof (screen recording or screenshot) is required. PRs without applicable visual documentation may not be reviewed until provided. You can add it by:
|
5 participants
Electron portion of #447
┆Issue is synchronized with this Notion page by Unito