ci(bump-callers): wire cloud-code-bot review identity into flagged callers (BE-1814)#32
ci(bump-callers): wire cloud-code-bot review identity into flagged callers (BE-1814)#32mattmillerai wants to merge 1 commit into
Conversation
…llers (BE-1814) Story 1.3 of BE-1800: fan out the optional bot-identity wiring the reusable cursor-review.yml gained in Story 1.1 (PR #13) through the caller-bump workflow instead of hand-editing each consumer. - New idempotent helper .github/cursor-review/wire-bot-identity.py injects bot_app_id: ${{ vars.APP_ID }} under with: and BOT_APP_PRIVATE_KEY: ${{ secrets.CLOUD_CODE_BOT_PRIVATE_KEY }} under secrets:, preserving comments/formatting (line-based, not a YAML round-trip). - bump-cursor-review-callers.yml gains a per-caller wire_bot flag (4th field); flagged only for repos that already hold the creds (cloud, mcp-server, comfy-inapp-agent, Comfy-iOS). Others stay github-actions[bot] (non-breaking). - Skip check is now content-based so a wiring-only change still opens a PR. - Unit tests for the helper run under the existing test-cursor-review-scripts CI.
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 39 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
ELI-5
The cursor-review bot can now post its review under a dedicated cloud-code-bot identity instead of the generic
github-actions[bot](that ability landed in Story 1.1, PR #13). Each consumer repo has to opt in by adding two lines to its thin caller: the app id (bot_app_id) and the paired private key secret. Rather than hand-edit every repo, this teaches the existing caller-bump workflow to add those two lines automatically — but only for the repos that actually hold the cloud-code-bot creds. Repos without the creds are untouched and keep posting asgithub-actions[bot].What & why
Story 1.3 of BE-1800, refit to the existing
cloud-code-botcreds (vars.APP_ID= app 2016716 /secrets.CLOUD_CODE_BOT_PRIVATE_KEY). No new secrets to provision — each consumer maps creds it already has..github/cursor-review/wire-bot-identity.py(new) — idempotently injects into a caller:bot_app_id: ${{ vars.APP_ID }}as the first child ofwith:BOT_APP_PRIVATE_KEY: ${{ secrets.CLOUD_CODE_BOT_PRIVATE_KEY }}undersecrets:It edits only those two anchors (line-based, not a PyYAML round-trip) so the fan-out PR diff is exactly the wiring — the callers' comments, folded
diff_excludes, and SHA-pin lines are preserved byte-for-byte. Already-wired callers are a no-op.bump-cursor-review-callers.yml— eachCALLERSentry gains a 4thwire_botfield. When set, the caller is piped through the helper alongside the SHA bump. Flagged only for repos confirmed to hold the creds:cloud+comfy-cloud-mcp-server— already wired by hand ⇒ injection is a verified no-op (they still get the SHA bump).comfy-inapp-agent+Comfy-iOS— theircursor-review-auto-label.ymlcallers already usevars.APP_ID+secrets.CLOUD_CODE_BOT_PRIVATE_KEY, so the creds are provisioned. These are the repos this actually wires.comfy-local-mcp/ComfySwiftSDK/comfy-infra/ the public OSS repos (no cloud-code-bot creds), and notswarmhost(its own caller comment states the app isn't provisioned there yet).Added unit tests (
tests/test_wire_bot_identity.py, 8 cases) that run under the existingtest-cursor-review-scripts.ymlCI.Non-breaking / incremental: both
bot_app_id(input) andBOT_APP_PRIVATE_KEY(secret) are optional in the reusable workflow — a caller without them keeps posting asgithub-actions[bot].How it propagates
This PR gives the bump workflow the capability; the wiring lands in the consumer repos the next time the workflow runs — either on the next
cursor-review.ymlpush, or via a manualworkflow_dispatchafter merge (recommended, to propagate tocomfy-inapp-agent+Comfy-iOSimmediately without waiting for an upstream change).Verification
python3 -m unittest discoversuite green (22 tests: 8 new + 14 existing).bump_one's transform against the real remote callers:comfy-inapp-agent/Comfy-iOS→ SHA bump + wiring added (exactly 1bot_app_id+ 1BOT_APP_PRIVATE_KEY, valid YAML, parsed values are the ticket's mapping).cloud/mcp-server→ SHA bump only, wiring a verified no-op (no duplicate keys).swarmhost→ SHA bump only, no wiring.bash -non the extracted run script; confirmed no GitHub-Actions expression tokens leak into therun:block (they'd be interpolated at parse time).Judgment calls
grep -qF "$NEW_SHA"early-skip with a content-equality check (NEW_CONTENT == OLD_CONTENT). Intent (avoid no-op PRs) is preserved and generalized so a wiring-only change on an already-SHA-current caller still opens a PR. Idempotent injection guarantees convergence.wire_bot: deliberately conservative — flagged only where creds are provably present (existing wiring or an auto-label caller using the same app).swarmhostexcluded per its own caller's note. A repo that references a missing secret would still degrade safely togithub-actions[bot], but flagging one without the app would be misleading, so it's opt-in per caller.actions/checkoutSHA-pinned to match the repo's pin policy (README) andcursor-review.yml.