Skip to content

Remove redundant template_viewed PostHog event #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robinjhuang wants to merge 2 commits into
base: main
Choose a base branch
from
+1 −22
Open

Remove redundant template_viewed PostHog event #660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98bcd8c
Remove redundant template_viewed PostHog event
robinjhuang Mar 10, 2026
0521e2c
Remove trackTemplateViewed import from PostHogAnalytics
robinjhuang Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions site/src/components/PostHogAnalytics.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,21 +10,10 @@
trackSignupCtaClicked,
trackDownloadButtonClicked,
trackShareButtonClicked,
trackTemplateViewed,
} from '../lib/posthog';

initPostHog();

// Template detail page view
const detailPage = document.querySelector('.template-detail-page');
if (detailPage) {
const name = detailPage.getAttribute('data-template') || '';
const mediaType = detailPage.getAttribute('data-media-type') || '';
if (name) {
trackTemplateViewed(name, mediaType);
}
}

// Global click delegation
document.addEventListener('click', (e) => {
const target = e.target as HTMLElement;
Expand Down
12 changes: 1 addition & 11 deletions site/src/lib/posthog.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export function initPostHog(): void {
* All tracked events follow the object_verb taxonomy:
* - snake_case
* - past tense verbs
* - e.g. hub:run_button_clicked, hub:template_viewed
* - e.g. hub:run_button_clicked, hub:search_performed
*/
type EventProperties = Record<string, string | number | boolean | undefined>;

Expand Down Expand Up @@ -57,16 +57,6 @@ export function trackShareButtonClicked(templateName: string): void {
});
}

export function trackTemplateViewed(
templateName: string,
mediaType: string,
): void {
capture('hub:template_viewed', {
template_name: templateName,
media_type: mediaType,
});
}

export function trackSearchPerformed(query: string): void {
capture('hub:search_performed', {
query,
Expand Down
Loading