Add SSZ Support by jclapis · Pull Request #403 · Commit-Boost/commit-boost-client

jclapis · 2025-11-11T00:49:24Z

This is an update to #372 which is now obsolete, and adds robust SSZ support to get_header() and submit_block():

Support for multiple ACCEPT types
Support for dynamically converting SSZ requests when the relay only supports JSON
Ability to translate transparently from the type returned by the relay back to the type requested by the client (e.g. SSZ (client request) -> JSON (relay request / response) -> SSZ (client response))

Co-authored-by: eltitanb <lorenzo@gattaca.com> Co-authored-by: ltitanb <163874448+ltitanb@users.noreply.github.com> Co-authored-by: Manuel Iñaki Bilbao <manuel.bilbao@lambdaclass.com>

Co-authored-by: ltitanb <163874448+ltitanb@users.noreply.github.com>

…st-client into sigp-audit-fixes

Co-authored-by: eltitanb <lorenzo@gattaca.com> Co-authored-by: ltitanb <163874448+ltitanb@users.noreply.github.com> Co-authored-by: Manuel Iñaki Bilbao <manuel.bilbao@lambdaclass.com>

Co-authored-by: ltitanb <163874448+ltitanb@users.noreply.github.com>

…-ssz-to-pbs

Co-authored-by: Manuel Iñaki Bilbao <manuel.bilbao@lambdaclass.com>

…t.rs

… 1.91 as required. Add audit.toml to ignore irrevelent audit error in CI.

…ate-v2

…ssing ignored mid_bid despite having the bid value available

back to v1

negotiation

ninaiiad · 2026-04-21T08:54:33Z

+/// Which encoding types the original requester accepts in the response.
+/// As the builder spec adds more encoding types, this struct can be expanded.
+#[derive(Clone)]
+pub struct AcceptTypes {


these seem to be unused, can delete? also we should have a clippy check that would flag things like that in CI

ninaiiad · 2026-04-21T08:56:13Z

    let (mux_lookup, registry_muxes) = match config.muxes {
        Some(muxes) => {
-            let (mux_lookup, registry_muxes) =
+            let (mux_lookup, registry_muxes): (_, _) =


nit: can remove type annotation

ninaiiad · 2026-04-21T08:56:21Z

    let (mux_lookup, registry_muxes) = match cb_config.muxes {
        Some(muxes) => {
-            let (mux_lookup, registry_muxes) = muxes
+            let (mux_lookup, registry_muxes): (_, _) = muxes


ninaiiad · 2026-04-21T08:58:07Z

+
+            let parsed = match mt.essence().to_string().as_str() {
+                APPLICATION_OCTET_STREAM => Some(EncodingType::Ssz),
+                APPLICATION_JSON | WILDCARD => Some(EncodingType::Json),


is wildcard actually a valid json? should this match have two branches maybe: ssz <-> json?
there is a comment below that says "Assume missing Content-Type means JSON" too - ??

ninaiiad · 2026-04-21T08:58:56Z

+    .ok()
+}
+
+/// Enum for types that can be used to encode incoming request bodies or


nit: redundant comment

ninaiiad · 2026-04-21T09:15:12Z

+
+    /// The accepted encoding types from the original request, ordered by
+    /// descending caller preference (q-value).
+    accepted_types: Vec<EncodingType>,


this is max two values, right? can we actually get two accepted types and not one for a single request? if yes, can do an ArrayVec then, otherwise one value is enough

ninaiiad · 2026-04-21T09:18:29Z

+
+        match code {
+            StatusCode::ACCEPTED => {
+                return Ok(SubmitBlockResponseInfo {


maybe do an option instead? too expensive for a dummy value

ninaiiad · 2026-04-21T09:22:46Z

+/// response, leaving the raw bytes intact for direct forwarding to the caller.
+/// Used in `HeaderValidationMode::None` where expensive crypto/structural
+/// checks are skipped.
+async fn send_get_header_light(


looks like this does pretty much the same thing as the _full version, so the inside part of these can be extracted
can do single function returning the raw response_bytes + content_type + fork, with a single decode step driven by a flag for the full / light

ninaiiad · 2026-04-21T09:23:38Z

+
+/// Send and lightly process a submit_block request, minimizing the amount of
+/// decoding and validation done
+async fn send_submit_block_light(


same here - some duplicate code with the send_submit_block_full that can be extracted

ninaiiad · 2026-04-21T09:46:25Z

+pub const CONSENSUS_VERSION_HEADER: &str = "Eth-Consensus-Version";
+
+lazy_static! {
+    static ref SSZ_VALUE_OFFSETS_BY_FORK: HashMap<ForkName, usize> = {


don't think we need a hashmap for this, performance-wise inlining the get_ssz_value_offset_for_fork should do better

eserilev and others added 30 commits February 5, 2025 13:37

Add builder ssz flow

3a2c7d5

Integration tests, fixes, and clippy/linting

5059593

resolve merge conflicts

35b8542

resolve merge conflictds

4acddbe

fix tests

7005422

CBST2-04: Update JWT secrets on reload and revoke module endpoint (#295)

5935659

Merge branch 'main' into sigp-audit-fixes

91f2cb4

Merge branch 'main' into sigp-audit-fixes

46e6f94

Merge branch 'main' into sigp-audit-fixes

b802fec

Merge branch 'main' into sigp-audit-fixes

151e811

CBST2-02: Make proposer commitment signatures unique to modules (#329)

498eed9

Co-authored-by: eltitanb <lorenzo@gattaca.com> Co-authored-by: ltitanb <163874448+ltitanb@users.noreply.github.com> Co-authored-by: Manuel Iñaki Bilbao <manuel.bilbao@lambdaclass.com>

Split request_signature into separate paths that return JSON (#350)

af13089

Co-authored-by: eltitanb <lorenzo@gattaca.com> Co-authored-by: ltitanb <163874448+ltitanb@users.noreply.github.com> Co-authored-by: Manuel Iñaki Bilbao <manuel.bilbao@lambdaclass.com>

Add nonce and chain ID to signature requests (#354)

0ef8787

Co-authored-by: eltitanb <lorenzo@gattaca.com> Co-authored-by: ltitanb <163874448+ltitanb@users.noreply.github.com> Co-authored-by: Manuel Iñaki Bilbao <manuel.bilbao@lambdaclass.com>

Merge branch 'main' into sigp-audit-fixes

ee18aa1

Merge main to sigp-audit-fixes (#361)

6988444

Co-authored-by: ltitanb <163874448+ltitanb@users.noreply.github.com>

Merge branch 'sigp-audit-fixes' of github.com:Commit-Boost/commit-boo…

25bd5a6

…st-client into sigp-audit-fixes

Add payload hash to signer JWT claims (#356)

52aec57

Co-authored-by: eltitanb <lorenzo@gattaca.com> Co-authored-by: ltitanb <163874448+ltitanb@users.noreply.github.com> Co-authored-by: Manuel Iñaki Bilbao <manuel.bilbao@lambdaclass.com>

Merge branch 'main' into sigp-audit-fixes

f2a275b

Add TLS to signer (#357)

6b14d77

Co-authored-by: eltitanb <lorenzo@gattaca.com> Co-authored-by: ltitanb <163874448+ltitanb@users.noreply.github.com> Co-authored-by: Manuel Iñaki Bilbao <manuel.bilbao@lambdaclass.com>

Removed old dependency (#370)

eb61667

Merge main to sigp audit fixes (#371)

2dfe96b

Co-authored-by: ltitanb <163874448+ltitanb@users.noreply.github.com>

Started porting #252 back to main

06c207f

Finished porting, successful tests

24fabca

Merge remote-tracking branch 'eserilev/add-builder-ssz-flow' into add…

f0875cd

…-ssz-to-pbs

Cleaned up merge

bad5675

Fixed clippy

50fccb5

Swapped to LH's ForkName enum

86fa858

Refactored encoding type support based on feedback

e7335f6

Fixed clippy

8c82b84

Fix misc findings from reaudit (#376)

d566dea

Co-authored-by: Manuel Iñaki Bilbao <manuel.bilbao@lambdaclass.com>

jclapis added 5 commits February 9, 2026 12:12

Merge branch 'main' into ssz-update-v2

e30cbde

Merge branch 'main' into ssz-update-v2

ff0b3ef

Merge branch 'main' into sigp-audit-fixes

02364f3

Merge branch 'main' into ssz-update-v2

a5d444d

Merge branch 'main' into sigp-audit-fixes

533e4c0

jclapis mentioned this pull request Mar 2, 2026

Add SSZ to PBS #372

Closed

JasonVranek mentioned this pull request Mar 3, 2026

Add microbenchmarking #432

Closed

JasonVranek and others added 6 commits March 17, 2026 13:27

Merge remote-tracking branch 'upstream/main' into sigp-audit-fixes

4681103

improve tls/cert config testing

9782d22

more util test coverage and remove duplicate env read from docker_ini…

bb28eb0

…t.rs

Bump lh from v8.0.0-rc.0 to stable v8.0.0, and bump rust from 1.89 to…

511d07d

… 1.91 as required. Add audit.toml to ignore irrevelent audit error in CI.

bump rust toolchain to nightly-2026-01-01

4afbf35

Add support for validation bypassing (#422)

48e1eec

JasonVranek requested a review from a team March 23, 2026 21:10

JasonVranek added 4 commits March 23, 2026 16:00

Merge remote-tracking branch 'upstream/sigp-audit-fixes' into ssz-upd…

7ddda6d

…ate-v2

address review comments

717390e

Merge remote-tracking branch 'upstream/sigp-audit-fixes' into ssz-upd…

a949c83

…ate-v2

Improve testing around SSZ/validation bypassing. Fix issue where bypa…

5daf7f9

…ssing ignored mid_bid despite having the bid value available

JasonVranek force-pushed the ssz-update-v2 branch from df936ef to 5daf7f9 Compare March 26, 2026 21:52

JasonVranek added 10 commits April 17, 2026 15:40

Merge branch 'main' into ssz-update-v2

788c1fc

fix deploy docs

ed6ead5

Lighthouse v8.0.0 → v8.1.3 migration for security

a59bd19

just fmt

e562003

remove all hardcoded ports from tests

8edbc5a

local audit fix: forward v1 payload to BN when submit_block v2 falls

36d604c

back to v1

local audit fix: tolerate Content-Type MIME params on relay responses

f4f1b2f

local audit fix: restrict SSZ→JSON retry to 406/415 per builder-spec

1927bce

local audit fix: honor Accept q-value ordering for deterministic content

0fcf9bc

negotiation

fix warnings + add more integration tests

6007fe5

ninaiiad suggested changes Apr 21, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add SSZ Support#403

Add SSZ Support#403
jclapis wants to merge 95 commits intomainfrom
ssz-update-v2

jclapis commented Nov 11, 2025 •

edited

Loading

Uh oh!

ninaiiad Apr 21, 2026

Uh oh!

ninaiiad Apr 21, 2026

Uh oh!

ninaiiad Apr 21, 2026

Uh oh!

ninaiiad Apr 21, 2026

Uh oh!

ninaiiad Apr 21, 2026

Uh oh!

ninaiiad Apr 21, 2026

Uh oh!

ninaiiad Apr 21, 2026

Uh oh!

ninaiiad Apr 21, 2026

Uh oh!

ninaiiad Apr 21, 2026

Uh oh!

ninaiiad Apr 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

jclapis commented Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jclapis commented Nov 11, 2025 •

edited

Loading