Skip to content

Support custom chain ids #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ManuelBilbao merged 4 commits into from
Mar 2, 2026
Merged

Support custom chain ids #429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d4341c2
add chain_id to Custom chains + remove helder
JasonVranek Feb 25, 2026
f55ae3d
fix broken pbs config tests
JasonVranek Feb 25, 2026
122644c
just fmt
JasonVranek Feb 25, 2026
96d8640
add a custom kurtosis spec file to test against to replace helder
JasonVranek Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions config.example.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
# Some fields are optional and can be omitted, in which case the default value, if present, will be used.

# Chain spec ID. Supported values:
# A network ID. Supported values: Mainnet, Holesky, Sepolia, Helder, Hoodi. Lower case values e.g. "mainnet" are also accepted
# A network ID. Supported values: Mainnet, Holesky, Sepolia, Hoodi. Lower case values e.g. "mainnet" are also accepted
# A custom object, e.g., chain = { genesis_time_secs = 1695902400, path = "/path/to/spec.json" }, with a path to a chain spec file, either in .json format (e.g., as returned by the beacon endpoint /eth/v1/config/spec), or in .yml format (see examples in tests/data).
# A custom object, e.g., chain = { genesis_time_secs = 1695902400, slot_time_secs = 12, genesis_fork_version = "0x01017000" }.
# A custom object, e.g., chain = { genesis_time_secs = 1695902400, slot_time_secs = 12, genesis_fork_version = "0x01017000", chain_id = 17000 }.
chain = "Holesky"

# Configuration for the PBS module
Expand Down
5 changes: 4 additions & 1 deletion crates/common/src/config/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ impl CommitBoostConfig {
let chain = match helper_config.chain {
ChainLoader::Path { path, genesis_time_secs } => {
// check if the file path is overridden by env var
let (slot_time_secs, genesis_fork_version, fulu_fork_slot) =
let (slot_time_secs, genesis_fork_version, fulu_fork_slot, chain_id) =
if let Some(path) = load_optional_env_var(CHAIN_SPEC_ENV) {
load_chain_from_file(path.parse()?)?
} else {
Expand All @@ -79,6 +79,7 @@ impl CommitBoostConfig {
slot_time_secs,
genesis_fork_version,
fulu_fork_slot,
chain_id,
}
}
ChainLoader::Known(known) => Chain::from(known),
Expand All @@ -87,13 +88,15 @@ impl CommitBoostConfig {
slot_time_secs,
genesis_fork_version,
fulu_fork_slot,
chain_id,
} => {
let genesis_fork_version: ForkVersion = genesis_fork_version.as_ref().try_into()?;
Chain::Custom {
genesis_time_secs,
slot_time_secs,
genesis_fork_version,
fulu_fork_slot,
chain_id,
}
}
};
Expand Down
4 changes: 0 additions & 4 deletions crates/common/src/signature.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,10 +106,6 @@ mod tests {
compute_domain(Chain::Sepolia, APPLICATION_BUILDER_DOMAIN),
Chain::Sepolia.builder_domain()
);
assert_eq!(
compute_domain(Chain::Helder, APPLICATION_BUILDER_DOMAIN),
Chain::Helder.builder_domain()
);
assert_eq!(
compute_domain(Chain::Hoodi, APPLICATION_BUILDER_DOMAIN),
Chain::Hoodi.builder_domain()
Expand Down
Loading