Skip to content

Fix unassigned variable #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MartinBraquet merged 39 commits into from
May 21, 2026
+5 −5
Merged

Fix unassigned variable #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
3a60fa2
Added Database checks to the onboarding flow
O-Bots Feb 22, 2026
ee0c4a5
Added compatibility page setup
O-Bots Feb 25, 2026
a7bbe2d
Finished up the onboarding flow suite
O-Bots Mar 4, 2026
dce1993
.
O-Bots Mar 4, 2026
0b05110
Fix: Merge conflict
O-Bots Mar 11, 2026
c04e29e
.
O-Bots Mar 13, 2026
932cb34
Fix: Added fix for None discriptive error issue #36
O-Bots Mar 15, 2026
6d976b1
Linting and Prettier
O-Bots Mar 15, 2026
77ab518
Minor cleaning
MartinBraquet Mar 15, 2026
a862dfe
Organizing helper func
O-Bots Mar 16, 2026
aba6d55
Added Google account to the Onboarding flow
O-Bots Mar 17, 2026
ec39152
Added account cleanup for google accounts
O-Bots Mar 18, 2026
85ccdfd
Started work on Sign-in tests
O-Bots Mar 25, 2026
04c18ae
Linting and Prettier
O-Bots Mar 25, 2026
d38f939
Added checks to the deleteUser func to check if the accout exists
O-Bots Mar 26, 2026
3f47d52
Linting and Prettier
O-Bots Mar 26, 2026
37d1f31
Formatting update, fixed homePage locator for signin
O-Bots Apr 2, 2026
9cbf87c
.
O-Bots Apr 2, 2026
6529a88
.
O-Bots Apr 2, 2026
316e1f9
.
O-Bots Apr 2, 2026
89d392f
Coderabbitai fix's
O-Bots Apr 2, 2026
14f32e6
Fix
MartinBraquet Apr 3, 2026
8329ed0
Improve test utilities and stabilize onboarding flow tests
MartinBraquet Apr 3, 2026
576d4c0
Changes requested
O-Bots Apr 3, 2026
a0e4794
Changed POM/Fixture structure to use an app class to instantiate the …
O-Bots Apr 4, 2026
35f3e2a
Apply suggestion from @MartinBraquet
MartinBraquet Apr 4, 2026
dcbb7d3
Delete .vscode/settings.json
MartinBraquet Apr 4, 2026
e2f1bc8
Apply suggestion from @MartinBraquet
MartinBraquet Apr 4, 2026
cc3d85f
Apply suggestion from @MartinBraquet
MartinBraquet Apr 4, 2026
946bfea
Apply suggestion from @MartinBraquet
MartinBraquet Apr 4, 2026
11cf0c7
Linting and Prettier
O-Bots Apr 4, 2026
d6e165f
Updated People page
O-Bots May 11, 2026
2920e81
Fix app.ts
O-Bots May 11, 2026
e7ae493
Updated peoplePage.ts: continued adding functions to use filters
O-Bots May 12, 2026
5aa8a54
Coderabbitai fix's
O-Bots Apr 2, 2026
9d48633
.
O-Bots May 12, 2026
c1c9eee
Updated People page
O-Bots May 20, 2026
07c0eca
Lint and Prettier
O-Bots May 20, 2026
410f2a1
.
O-Bots May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tests/e2e/web/pages/peoplePage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,8 +427,8 @@ export class PeoplePage {

async verifyNumberOfMatchingProfiles(count: number) {
await expect(this.profileCount).toBeVisible()
const test = await this.profileCount.textContent()
if (!test) return
expect(actual).toStrictEqual(expected)
const actualCount = await this.profileCount.textContent()
if (!actualCount) return
expect(parseInt(actualCount)).toStrictEqual(count)
}
Comment on lines 428 to 433
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Silent early return masks failures and textContent() skips Playwright auto-waiting.

Two concerns with the new assertion logic:

  1. if (!actualCount) return turns a missing/empty profile-count element into a silent pass. A verification method should fail loudly when the value under test cannot be read — otherwise a regression that empties the count element will go undetected.
  2. textContent() is a one-shot DOM read with no retry. If the count updates asynchronously after applying filters, the assertion can race the UI. Prefer expect(locator).toHaveText(...), which auto-waits/retries until the timeout, eliminating the need to manually parse and guard.
♻️ Suggested refactor 
   async verifyNumberOfMatchingProfiles(count: number) {
     await expect(this.profileCount).toBeVisible()
-    const actualCount = await this.profileCount.textContent()
-    if (!actualCount) return
-    expect(parseInt(actualCount)).toStrictEqual(count)
+    await expect(this.profileCount).toHaveText(String(count))
   }

If the element contains additional text around the number (e.g. "42 profiles"), use a regex variant instead:

await expect(this.profileCount).toHaveText(new RegExp(`\\b${count}\\b`))
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/e2e/web/pages/peoplePage.ts` around lines 428 - 433, The current
verifyNumberOfMatchingProfiles silently returns when textContent() is falsy and
uses textContent() which doesn't auto-wait; instead remove the silent early
return and replace the manual read+parse with Playwright's auto-waiting
assertion on the locator (this.profileCount) — e.g. use
expect(this.profileCount).toHaveText(count.toString()) or, if the element
contains extra text, expect(this.profileCount).toHaveText(new
RegExp(`\\b${count}\\b`)); keep or drop the explicit visibility check as desired
but do not use textContent() nor an early return in
verifyNumberOfMatchingProfiles so failures surface reliably.

}
2 changes: 1 addition & 1 deletion tests/e2e/web/specs/signIn.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,4 @@ test.describe('when given invalid input', () => {
page.getByText('Failed to sign in with your email and password', {exact: true}),
).toBeVisible()
})
})
})
2 changes: 1 addition & 1 deletion tests/e2e/web/specs/signUp.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,4 @@ test.describe('when an error occurs', () => {
await app.signUp.verifyUsernameError()
await expect(app.signUp.nextButtonLocator).toBeDisabled()
})
})
})
Loading