T3059 fcp lifecycle events

[Danielgergely]

• FIX: take all events, sort by date descending, take first date and calculate state according to this event
• FIX: post-migration script should now update the last event date on all projects
• FIX: changed the sorting of the lifecycle events in the projects view
• FIX: updated module version

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the handling of FCP lifecycle events to ensure accurate and consistent state calculation and display. It introduces a more robust method for identifying the latest lifecycle event, includes a migration script to update existing project data, and improves the user interface by sorting lifecycle events chronologically.

Highlights

• Lifecycle Event Calculation Logic: The method for determining the last lifecycle event for FCP projects has been significantly revised to accurately identify the most recent event by sorting all associated events by date in descending order.
• Post-Migration Script: A new post-migration script was introduced to recompute the lifecycle state and suspension status for all existing FCP projects, ensuring data consistency across the system after the logic change.
• User Interface Sorting: The default sorting order for lifecycle events displayed within the project view has been updated to present the most recent events first, improving usability.
• Module Version Update: The module version has been incremented from 14.0.1.5.0 to 14.0.1.6.0.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses an issue in determining the correct lifecycle state for FCP projects by improving the sorting logic for lifecycle events. It correctly sorts events by date to find the most recent one. A post-migration script is included to update existing projects, and a UI change ensures consistent sorting in the project view. The changes are logical and well-implemented, though I have a couple of minor suggestions for improving code clarity and robustness.