Skip to content

[T3064] FIX: interaction resume now contains contactus form submissions#2085

Merged
ecino merged 2 commits into14.0from
T3064-contactus-form-interaction-resume
Mar 26, 2026
Merged

[T3064] FIX: interaction resume now contains contactus form submissions#2085
ecino merged 2 commits into14.0from
T3064-contactus-form-interaction-resume

Conversation

@Danielgergely
Copy link
Copy Markdown
Member

  • FIX: search for crm claims even if no partner is added. use the email address to match to partner.

- FIX: search for crm claims even if no partner is added. use the email address to match to partner.
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the interaction resume functionality by integrating contact form submissions into the communication timeline. It also refines the system's ability to link CRM claims to partners, particularly for anonymous users, by intelligently using email addresses to establish connections and trigger necessary interaction updates.

Highlights

  • Contact Form Submissions: Included contact form submissions in the interaction resume data for CRM requests, ensuring they are visible in the communication timeline.
  • Enhanced Partner Association: Improved partner association for CRM claims by searching for partners using email addresses when a direct partner ID is not initially available, ensuring timeline updates for anonymous users.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request enhances the interaction data collection for CRM requests by including the crm.claim itself as an interaction and ensuring that partner timelines are updated for both new claims and messages, even when the partner is initially anonymous and identified only by email. A key review comment highlights a potential issue where adding the crm.claim as an interaction could lead to duplicate entries if the claim's initial message is also processed, suggesting that the claim.incoming_message_id should be excluded from subsequent message processing to prevent this redundancy.

@Danielgergely
Copy link
Copy Markdown
Member Author

image

@ecino ecino merged commit 28380a3 into 14.0 Mar 26, 2026
1 check passed
@ecino ecino deleted the T3064-contactus-form-interaction-resume branch March 26, 2026 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants