[T2747] FIX: moved state update to after payment configuration

[ecino]

• FIX: changing state triggers the creation of the communication job, but the payment information/pdf is not yet in the db at the time. This should solve that issue. Testing is still needed!

See also CompassionCH/compassion-switzerland#1747

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical timing issue where communication jobs were being triggered before essential payment configuration data was fully written to the database. By reordering the contract state update and introducing explicit database flush operations, the change ensures that all necessary payment information is persistently stored prior to activating the contract and initiating any dependent communication processes, thereby preventing potential data inconsistencies and ensuring reliable communication.

Highlights

• State Update Timing: The contract state update to 'active' was relocated within the contract_active method to ensure it occurs after payment configuration is fully processed.
• Database Flushing: Explicit flush() calls were added for res.partner and recurring.contract models to guarantee that payment-related data is persisted to the database before the contract state is marked as active, preventing race conditions.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the contract_active method to ensure payment mode data is flushed to the database before activating the contract and triggering an auto-communication job. A review comment suggests refining the flush() calls to be more specific to the modified recordsets, rather than flushing the entire model, to prevent potential unintended side effects.