[MIG] forward-port changes from 14.0

[ecino]

No description provided.

[gemini-code-assist]

Code Review

This pull request introduces several enhancements and fixes across multiple modules. Key changes include the implementation of GPS coordinate obfuscation for projects using the Google Maps API, improved lifecycle event tracking, and a new automated communication system for project suspensions and follow-ups. Additionally, it introduces categories for communication snippets, updates analytic account structures, and refines language detection for correspondence. Feedback was provided regarding a missing email template body, the use of broad exception handling, and hardcoded IDs in migration scripts.

[gemini-code-assist]

The email template email_project_suspension_follow_up is defined without a body_html field. This will result in sending an empty email when this template is used, for example when a project is reactivated or in the 2-month suspension follow-up cron. You should add a body to this template to provide meaningful information to the recipient.

        <record id="email_project_suspension_follow_up" model="mail.template">
            <field name="name">FCP Suspension Follow Up</field>
            <field
        name="model_id"
        ref="partner_communication.model_partner_communication_job"
      />
            <field name="use_default_to" eval="True" />
            <field
        name="subject"
      >Additional information about the center</field>
            <field
        name="email_from"
      >"${object.user_id.company_id.name}" &lt;${object.user_id.company_id.email}&gt;</field>
            <field name="body_html" type="html">
                <div>
                    % set child = object.get_objects()
                    % set project = child.mapped('project_id')[0]
                    % set last_lifecycle = project.last_lifecycle_id
                </div>
                <p>
                    ${object.partner_id.salutation},
                    <br /><br />
                    This is a follow-up regarding the center ${project.fcp_id}.
                    <br /><br />
                    <!-- TODO: Add relevant information based on the context (e.g., reactivation, continued suspension) -->
                    <br /><br />
                    Yours sincerely
                </p>
            </field>
        </record>

[gemini-code-assist]

The try...except block uses a broad except Exception. This can hide unexpected errors and make debugging more difficult. It's better to catch more specific exceptions that you expect to handle, such as requests.exceptions.RequestException for network issues, and KeyError or IndexError for issues with the response data structure.

Suggested change

	except Exception:
	except (requests.exceptions.RequestException, KeyError, IndexError):

[gemini-code-assist]

Using a hardcoded ID 1 for the default configuration is fragile and might break if the record ID changes in different environments. It's safer to look up the record using its XML ID.

Suggested change

	logs.write(
	{"config_id": 1}
	) # Set to Default config (ID=1) to avoid orphaned logs
	default_config = env.ref('partner_communication.default_communication', raise_if_not_found=False)
	if default_config:
	logs.write({"config_id": default_config.id})