-
Notifications
You must be signed in to change notification settings - Fork 10
T2534 payment method storing and management #231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SamBachmann
wants to merge
72
commits into
14.0
Choose a base branch
from
T2534-Payment-Method-storing-and-management
base: 14.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
72 commits
Select commit
Hold shift + click to select a range
f797051
[T2534] FEAT add a method to get payment info into ContractGroup
SamBachmann 645112c
[T2534] FEAT add a modal to update/add payment method
SamBachmann 92cb3fe
[T2534] FEAT update controller to handle the groups of sponsorships
SamBachmann 20dc677
[T2534] FEAT group sponsorships by payment methods
SamBachmann cd6aeaf
[T2534] REFACTOR group sponsorships by payment methods
SamBachmann c4c6f1c
[T2534] REFACTOR update manifest and separate templates
SamBachmann 5d8e76b
[T2534] REFACTOR update manifest and separate templates
SamBachmann b81a117
[T2534] REFACTOR update contract_group.py logic
SamBachmann 6f76b40
[T2534] REFACTOR add bvr number if it exist & code refactoring
SamBachmann 6db5205
[T2534] FEAT add "add payment method" Button
SamBachmann e7609aa
[T2534] FEAT update the update/change/add payment modal to be working
SamBachmann 591548b
[T2534] FEAT methods for change and update payments methods
SamBachmann 2385e3e
[T2534] Backup JS
SamBachmann 94fc396
[T2534] FEAT add style to Payment cards
SamBachmann 4238b13
[T2534] FEAT Make possible for a user to change his payment method fo…
SamBachmann 9a406ac
[T2534] FIX add CSS file for the payment selection modal
SamBachmann 0f3e8bf
[T2534] FEAT Can switch between methods in update with collapsible se…
SamBachmann 82a2f31
[T2534] FIX Use less of JS
SamBachmann a0a4e62
[T2534] REFACTOR clean up the js
SamBachmann f714acd
[T2534] FIX get all the payment methods and pass it to the my_donatio…
SamBachmann 54c880e
[T2534] FIX refactor templates
SamBachmann ffe6f0b
[T2819] FEAT Better displaying for modal and collapsible sections
SamBachmann 12726b5
[T2819] FIX Smother experience reloading the page after save a change…
SamBachmann a3b8cfe
[T2534] FIX selection of cards in modals
SamBachmann 8f1b593
[T2534] FEAT add a new payment method from donation page
SamBachmann ffbb782
[T2534] FIX make possible the save of payment methods from checkout
SamBachmann 40e152a
[T2534] FIX Improve create_from_transaction logic
SamBachmann b6a928a
[T2534] FIX Adapt icon size
SamBachmann fddfa9c
[T2534] FIX Retrieve all valid groups linked to a partner
SamBachmann b238b83
[T2534] FEAT display toast after returning from add a payment method
SamBachmann ca7236d
[T2534] REFACTOR refactor the code (docs unused methods)
SamBachmann 9e04182
[T2534] REFACTOR refactor the code (docs unused methods)
SamBachmann 19587ec
[T2534] REFACTOR UI addjusting for payment modal and payment cards
SamBachmann 737ae51
[T2534] FIX Improve error toast displaying when returning from a paym…
SamBachmann e944c74
[T2534] FIX remove useless operations
SamBachmann ff970ac
[T2534] FEAT make the update payment method logic working
SamBachmann e45b176
[T2534] REFACTOR change doc in xml files
SamBachmann ee8a972
[T2534] FIX update payment method for a group infinite looping
SamBachmann e0bf524
[T2534] REFACTOR remove functionalities related to payment method acq…
SamBachmann c0495e9
[T2534] REFACTOR precommit formating
SamBachmann 476a9a1
[T2534] REFACTOR remove logs
SamBachmann 4a16e18
[T2534] FIX support LSV contract properly
SamBachmann a2bdf75
[T2534] FIX serialize event details for group change
SamBachmann 5e5abb4
[T2534] FIX remove unused variable
SamBachmann 492284a
[T2534] FIX simplify comments
SamBachmann f33dc42
[T2534] FIX prevent memory leak in widget end of life
SamBachmann bfe467f
[T2534] FIX remove ref field (as it is computed internally now)
SamBachmann d213c4f
[T2534] FIX add security check when changing a contract from a group …
SamBachmann 3439281
[T2534] FIX prevent memory leak in widget
SamBachmann 7cbac75
[T2534] REFACTOR retrieve bvr_reference from a backend function
SamBachmann 20bbd54
[T2534] REFACTOR Change modal btn label from Save change to Save
SamBachmann 3cb56ba
[T2534] FIX add variable in css
SamBachmann fc9f1a4
[T2534] FIX remove stylesheet link from xml my2_payment_method_card.xml
SamBachmann 28fb20f
[T2534] FIX allow changing the ref of a group where it is lacking
SamBachmann 85031f7
[T2534] FIX make the displayed string translatable
SamBachmann 3cef023
[T2534] REFACTOR run precommit formating
SamBachmann 757014b
[T2534] FIX remove duplicate line
SamBachmann a0848b8
[T2534] FIX remove duplicate line
SamBachmann 0b30348
[T2534] FIX precommit
SamBachmann c5a2656
[T2534] REFACTOR move # of contract per group calculation to the backend
SamBachmann 5df61c0
[T2534] FIX typo in Toast message
SamBachmann d4d3f42
[T2534] REFACTOR donation page to be able to not reload the page afte…
SamBachmann d5b8b83
[T2534] REFACTOR donation page
SamBachmann a714e73
[T2534] REFACTOR implement the optimistic UI reloading
SamBachmann d83648b
[T2534] REFACTOR implement the optimistic UI reloading
SamBachmann c83db3f
[T2846] REFACTOR save payment methods as a state and prevent JSON issues
SamBachmann 9f6d8a1
[T2846]FIX precommit
SamBachmann 8a10ee8
[T2846]FIX remove Json from update btn
SamBachmann fd0b8d5
[T2534] FIX precommit
SamBachmann 88ceb66
[T2534] FIX translate error messages
SamBachmann f58dade
Merge branch '14.0-MyCompassion2.0' into T2534-Payment-Method-storing…
SamBachmann 192b980
[T2534] FIX remove console.log in js
SamBachmann File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <odoo> | ||
| <data noupdate="1"> | ||
| <record id="payment_mode_ebill" model="account.payment.mode"> | ||
| <field name="name">eBill</field> | ||
| <field name="company_id" ref="base.main_company"/> | ||
| <field name="bank_account_link">variable</field> | ||
| <field name="payment_method_id" ref="account.account_payment_method_manual_in"/> | ||
| <field name="active" eval="True"/> | ||
| </record> | ||
|
|
||
| <record id="account_payment_method_ebill" model="account.payment.method"> | ||
| <field name="name">eBill</field> | ||
| <field name="code">ebill</field> | ||
| <field name="payment_type">inbound</field> | ||
| </record> | ||
| </data> | ||
| </odoo> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Catching a broad
odoo.exceptions.ValidationErrorand returning a generic error message hides the specific reason for the failure from the user and makes debugging more difficult. For instance, if a unique constraint is violated, Odoo's default JSON-RPC error handling would provide a much more informative message.Consider removing this
try...exceptblock and letting Odoo's framework handle theValidationError. This will provide more meaningful feedback to the user.