[T3038] FIX: changed tab names to MyCompassion

[Danielgergely]

• FEAT: created an override template for titles in all MyCompassion pages
• FEAT: added template override to manifest

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request standardizes the website title across all MyCompassion pages by implementing a global title override. This change ensures consistent branding and user experience by displaying 'MyCompassion' in the browser tab for every page within the application.

Highlights

• Website Title Override: A new template has been introduced to override the default website title, ensuring all MyCompassion pages consistently display 'MyCompassion' in the browser tab.
• Manifest Update: The new title override template has been added to the module's manifest file, making it an integral part of the application's loaded assets.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• my_compassion/manifest.py
  • Added 'templates/website_title_override.xml' to the list of data files.
• my_compassion/templates/website_title_override.xml
  • Created a new XML template file.
  • Defined an Odoo template that inherits from 'website.layout'.
  • Used an XPath expression to replace the existing title element with a new one containing 'MyCompassion'.

Activity

• No specific review comments or activity have been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to change the browser tab title to 'MyCompassion' by overriding an Odoo template. No security vulnerabilities were identified. However, the current implementation incorrectly applies a static title to the entire website, negatively impacting SEO and user experience by removing dynamic page titles. Please address this fundamental issue by adopting a more targeted approach, as detailed in the critical comment. Additionally, consider improving code maintainability by following best practices for naming template IDs, as suggested in the medium-severity comment.

[NoeBerdoz]

Thanks for the proposition!

But actually, it's not the wanted approach, I'm sorry I should have been clearer on the task description, that's on me.

The issue is that, our pages names are inconsistent, sometimes MC2 shows "My Compassion 2 <page_name> " sometimes "My account", sometimes, something else, etc.

We need to review the individual templates for the portal pages. Odoo naturally constructs the tab title using the template's name attribute followed by the Website Name. We need to make them all consistent. The goal is for the platform to show tab names as so (which is the default Odoo way) <page_name> | My Compassion

Odoo's set the tab name as so: template name attribute + pipe "|" + website name.

Currently our website name is "MyCompassion", this can be change on production, in Website -> Configuration.

[NoeBerdoz]

I'm sorry @Danielgergely, you overengineered the solution here.

Here is what needs to be done:

Let's take the example of the template in my_compassion/templates/pages/my2_add_a_gift.xml

In the template declaration, the only thing to change is the attribute name

<template id="my2_add_a_gift_page" name="Add a Gift Page">

Here is the corrected code:

<template id="my2_add_a_gift_page" name="Add a Gift">

And ... that's it, that is what needs to be done on every views, in a consistent way.

You can refer to my previous review for more details, or you can hit me on Slack if it's not clear ;)

[Danielgergely]

@NoeBerdoz I do agree with you, that would be more straight forward, and that is how I started my approach. would have been a lot easier.
However, that would mean, that we can't translate the names of the pages, as odoo's translation does not detect the texts there. Additionally, we can't use dynamic names, like for the children's page or the gifts page. We could use additional_title attribute directly in the templates, but this also has the translation problem (texts are not detected).
So to summarize: to be able to use dynamic titles and translation, passing the already translated additional title to the master odoo template is the cleanest solution in my opinion. Let me know if you disagree and would still prefer the static version

[NoeBerdoz]

@Danielgergely Thank you for the clarification! I’ve looked into this further, and you are right we need this approach to ensure translations.

I would suggest a little change in it, for pages with fixed names (like Reset Password my2_change_password.xml), we can drop the Python controller overrides to simplify the code (and the upcoming migration to 18). Instead, we can move the titles directly into the XML templates using <t t-set="additional_title">Page Title</t>. And for pages that depend on record data, we can keep your current correct approach of passing additional_title in the request.render().