Skip to content

[T3053] FEAT: added optional text alignment to Banner component#306

Open
Danielgergely wants to merge 1 commit into14.0from
T3053-volunteer-page-translations
Open

[T3053] FEAT: added optional text alignment to Banner component#306
Danielgergely wants to merge 1 commit into14.0from
T3053-volunteer-page-translations

Conversation

@Danielgergely
Copy link
Copy Markdown
Member

  • FEAT: used in the call to action banner on the volunteer page

Related PR: CompassionCH/compassion-switzerland#1746

- FEAT: used in the call to action banner on the volunteer page
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new feature to the Banner component, enabling developers to specify text alignment for banner content. This enhancement provides greater flexibility in UI design, particularly for components like the call-to-action banner on the volunteer page, by allowing text to be aligned left, center, or right as needed.

Highlights

  • Banner Component Enhancement: Introduced an optional align_text parameter to the Banner component, allowing customization of text alignment.
  • Dynamic Text Alignment: Implemented dynamic application of text alignment classes to the banner's text content, defaulting to 'text-left' if no alignment is specified.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • theme_compassion_2025/templates/components/Banner.xml
    • Added align_text as an optional parameter for text alignment.
    • Modified the banner's text paragraph to dynamically apply the specified alignment class.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces an align_text property to the Banner component to allow for optional text alignment. While the implementation correctly applies alignment to the main text body, it doesn't affect the title or the button, which can lead to inconsistent visual styling. My review includes a suggestion to either update the implementation for more consistent behavior across all banner content or clarify the documentation to reflect the current limited scope.

@Danielgergely
Copy link
Copy Markdown
Member Author

PR: #304 should fix the pre-commit issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant