[T3072] FIX: clear donation item in case of abandoned cart#308
Conversation
Danielgergely
commented
Mar 23, 2026
- FIX: If the same product (amount) is selected after a cart has been abandoned, the correct name is shown (order line is cleared)
- FIX: If the same product (amount) is selected after a cart has been abandoned, the correct name is shown (order line is cleared)
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a bug where abandoned donation items were retained in the shopping cart, leading to incorrect order details if the user later selected the same product. The changes ensure that any existing order lines are cleared when a draft sale order is reused, providing a cleaner and more accurate cart experience for donations. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request aims to fix an issue with abandoned carts containing donations by clearing the order before adding a new donation. However, the current implementation clears the entire cart, which could lead to a poor user experience if other items are present. My review provides a more targeted fix that only removes previous donation lines, preserving the rest of the cart's contents.