Skip to content

[T3072] FIX: clear donation item in case of abandoned cart#308

Merged
ecino merged 1 commit into14.0from
T3072-musk-event-donation-bug
Mar 26, 2026
Merged

[T3072] FIX: clear donation item in case of abandoned cart#308
ecino merged 1 commit into14.0from
T3072-musk-event-donation-bug

Conversation

@Danielgergely
Copy link
Copy Markdown
Member

  • FIX: If the same product (amount) is selected after a cart has been abandoned, the correct name is shown (order line is cleared)

- FIX: If the same product (amount) is selected after a cart has been abandoned, the correct name is shown (order line is cleared)
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a bug where abandoned donation items were retained in the shopping cart, leading to incorrect order details if the user later selected the same product. The changes ensure that any existing order lines are cleared when a draft sale order is reused, providing a cleaner and more accurate cart experience for donations.

Highlights

  • Abandoned Cart Fix: Implemented a fix to ensure that when a cart containing a donation item is abandoned and then the same product is selected again, the previous donation line is cleared, preventing incorrect order line retention.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix an issue with abandoned carts containing donations by clearing the order before adding a new donation. However, the current implementation clears the entire cart, which could lead to a poor user experience if other items are present. My review provides a more targeted fix that only removes previous donation lines, preserving the rest of the cart's contents.

@ecino ecino merged commit a68e25f into 14.0 Mar 26, 2026
1 check passed
@ecino ecino deleted the T3072-musk-event-donation-bug branch March 26, 2026 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants