Skip to content

[T3066] FIX: hid cart in muskathlon events#310

Merged
ecino merged 5 commits into14.0from
T3066-muskathlon-cart
Mar 26, 2026
Merged

[T3066] FIX: hid cart in muskathlon events#310
ecino merged 5 commits into14.0from
T3066-muskathlon-cart

Conversation

@Danielgergely
Copy link
Copy Markdown
Member

@Danielgergely Danielgergely commented Mar 24, 2026

  • FIX: cart is now hidden on muskathlon website

- FIX: used css instead of templates/records (they just didn't want to work)
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a bug where the shopping cart was erroneously displayed during Muskathlon events. The fix involves applying a direct CSS rule to conceal the cart element, providing a quick and effective resolution to the visibility issue.

Highlights

  • Cart Visibility Fix: Implemented a CSS-based solution to hide the shopping cart in Muskathlon events, after attempts with template overrides were unsuccessful.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a CSS rule in custom.css to hide the shopping cart element (li.o_wsale_my_cart) using display: none !important;. The feedback indicates that this rule is too broad, as custom.css is globally loaded, which could inadvertently hide the cart across the entire website instead of just on Muskathlon event pages, leading to unintended side effects. Additionally, the use of !important is highlighted as a bad practice. A more scoped approach is suggested, involving adding a specific class to Muskathlon page templates and updating the CSS selector for better specificity and maintainability.

@NoeBerdoz NoeBerdoz requested a review from ecino March 25, 2026 15:02
@ecino ecino merged commit 03dfba5 into 14.0 Mar 26, 2026
1 check passed
@ecino ecino deleted the T3066-muskathlon-cart branch March 26, 2026 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants