[T3066] FIX: hid cart in muskathlon events#310
Conversation
- FIX: used css instead of templates/records (they just didn't want to work)
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a bug where the shopping cart was erroneously displayed during Muskathlon events. The fix involves applying a direct CSS rule to conceal the cart element, providing a quick and effective resolution to the visibility issue. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a CSS rule in custom.css to hide the shopping cart element (li.o_wsale_my_cart) using display: none !important;. The feedback indicates that this rule is too broad, as custom.css is globally loaded, which could inadvertently hide the cart across the entire website instead of just on Muskathlon event pages, leading to unintended side effects. Additionally, the use of !important is highlighted as a bad practice. A more scoped approach is suggested, involving adding a specific class to Muskathlon page templates and updating the CSS selector for better specificity and maintainability.
- FIX: using website.sudo() to only hide the cart for muskathlon
Uh oh!
There was an error while loading. Please reload this page.