[T2847] FIX: W&P check now happens when users enters birth date

[Danielgergely]

• FIX: added birthday change event handling and check to W&P form
• REFACTOR: changed var to const/let in JS file and extracted age check as a separate function
• FIX: sponsor me button now doesn't redirect to the profile page, but works as intended
• FIX: removed duplicate id from hidden birthdate input

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the user experience and code quality within the new sponsorship wizard. It primarily focuses on improving the 'Write & Pray' age verification process by making it more immediate and modular. Additionally, it includes general JavaScript refactoring and minor UI fixes to ensure smoother form interactions and correct display of elements.

Highlights

• Age Check for Write & Pray: The age check for the 'Write & Pray' form now triggers immediately when a user enters their birth date, ensuring compliance with age requirements upfront.
• Code Refactoring: JavaScript variable declarations were updated from 'var' to 'const'/'let' for improved scope management, and the age validation logic was extracted into a separate, reusable function.
• Sponsor Me Button Fix: A styling issue with the 'Sponsor me' button was resolved, ensuring it functions correctly and is properly layered on the page.
• Duplicate ID Removal: A redundant 'id' attribute was removed from a hidden birthdate input field to prevent potential DOM conflicts.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the new sponsorship wizard, primarily by updating var declarations to const/let and implementing a new age verification system for the 'Write & Pray' sponsorship type. The age check logic has been extracted into a dedicated method and integrated into the form flow, with an event listener for birthdate changes. Additionally, a z-index style was applied to the 'Sponsor me Button' div. Feedback includes correcting an incorrect JavaScript selector (input #birthdate), refactoring duplicated age verification logic in _onBirthDateChange to utilize the _checkWAPAge method, and moving the inline z-index style to a CSS class for improved maintainability.

[NoeBerdoz]

Thanks @Danielgergely, it's a great approach you are proposing there 👌

But I can't approve the PR as when testing the feature, I'm facing an error 400 for already logged-in users. (Maybe this issue was already there before your proposed changes, if so confirm it to me, then we will merge your PR and create a new ticket for the issue)

[NoeBerdoz]

Thanks