[T3087] FIX: redirect old child sponsor url#313
Conversation
Danielgergely
commented
Apr 1, 2026
- FIX: /child/<child_id>/sponsor is now redirected to the new /my2/new-sponsorship/<child_id>
- FIX: /child/<child_id>/sponsor is now redirected to the new /my2/new-sponsorship/<child_id>
There was a problem hiding this comment.
Code Review
This pull request introduces a redirection route to handle deprecated MyCompassion 1.0 links, mapping them to the new sponsorship page in version 2.0. The reviewer suggested using a string converter instead of a model converter for the route to prevent potential access control errors for public users and to improve efficiency by avoiding unnecessary database lookups. Implementing this change would also allow for the removal of the now-unused slug import.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces a redirection route for legacy child sponsorship links, ensuring compatibility between MyCompassion 1.0 and 2.0. The new route converts numeric IDs to slugs and preserves query parameters. A review comment suggests using urlencode for more robust and idiomatic query string handling in Odoo.