Skip to content

[T3087] FIX: redirect old child sponsor url#313

Merged
NoeBerdoz merged 2 commits into14.0from
T3087-redirect-legacy-child-pack
Apr 1, 2026
Merged

[T3087] FIX: redirect old child sponsor url#313
NoeBerdoz merged 2 commits into14.0from
T3087-redirect-legacy-child-pack

Conversation

@Danielgergely
Copy link
Copy Markdown
Member

  • FIX: /child/<child_id>/sponsor is now redirected to the new /my2/new-sponsorship/<child_id>

- FIX: /child/<child_id>/sponsor is now redirected to the new /my2/new-sponsorship/<child_id>
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a redirection route to handle deprecated MyCompassion 1.0 links, mapping them to the new sponsorship page in version 2.0. The reviewer suggested using a string converter instead of a model converter for the route to prevent potential access control errors for public users and to improve efficiency by avoiding unnecessary database lookups. Implementing this change would also allow for the removal of the now-unused slug import.

@Danielgergely
Copy link
Copy Markdown
Member Author

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a redirection route for legacy child sponsorship links, ensuring compatibility between MyCompassion 1.0 and 2.0. The new route converts numeric IDs to slugs and preserves query parameters. A review comment suggests using urlencode for more robust and idiomatic query string handling in Odoo.

Copy link
Copy Markdown
Contributor

@NoeBerdoz NoeBerdoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@NoeBerdoz NoeBerdoz merged commit f32c736 into 14.0 Apr 1, 2026
1 check passed
@NoeBerdoz NoeBerdoz deleted the T3087-redirect-legacy-child-pack branch April 1, 2026 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants