[FIX][T2593] tagged_partner_count field set to store=False

[ecino]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a fix by modifying the tagged_partner_count field in the ResPartnerCategory model. The store=True attribute has been removed, ensuring that this computed field's value is always dynamically calculated rather than stored in the database, which can prevent potential data inconsistencies or performance issues. Additionally, minor code style improvements were applied to argument passing in method calls.

Highlights

• Field Definition Update: Removed the store=True attribute from the tagged_partner_count field definition, making it a purely computed field.
• Code Formatting: Improved the formatting of with_delay method calls within the create and write methods for better readability.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• partner_tag_smart_assignation/models/res_partner_category.py
  • Removed store=True from the tagged_partner_count field definition.
  • Refactored argument formatting for with_delay calls in create and write methods.

Activity

• Pull request opened by ecino.
• No further review activity or comments have been recorded yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request removes store=True from the tagged_partner_count field. This change introduces a significant performance risk (N+1 problem) if the field is used in list views. My review comment suggests either fixing the root cause of the update issue while keeping the field stored, or optimizing the compute method for batch processing if the field must be non-stored.

[gemini-code-assist]

Removing store=True can lead to significant performance degradation (the N+1 problem) when this field is used in a list view, as it would cause a separate database query for each row. It is highly recommended to keep store=True for performance reasons. If the stored value was not being updated correctly, the root cause of that issue should be investigated and fixed instead. If making this field non-stored is absolutely necessary, the compute method _compute_number_tags must be refactored to be batch-friendly to avoid the N+1 problem.