Pixel Size/Scaling Cleanup#1396
Draft
garrettwrong wants to merge 10 commits into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1396 +/- ##
===========================================
+ Coverage 90.56% 90.57% +0.01%
===========================================
Files 135 135
Lines 14691 14686 -5
===========================================
- Hits 13305 13302 -3
+ Misses 1386 1384 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleans up multiple issues with pixel size across the image/xform/filter/source components.
Resolves #1318 and fixes the introduced bugs, closing #1395 .
Adds unit tests covering the triggering situations of the bugs.
This should probably be rebased after the larger PR 1388.
Ironically, it was the single
# Assign correct pixel_sizeline inSimulationthat caused all the original problems, because it was assigning the wrong pixel_size under downsampling.This caused some bugs (the math error in 1395) to be cancelled out, and workarounds to be added in other components... most of which I think only worked for
Simulations, not real data.... Hopefully that's better now.