Conversation
added 4 commits
January 23, 2026 16:02
the gcfg parser populates the fields with default values for that type, if that field is not present in the read config file. the config_helper was only checking if that field exists within that object instance, so it was always "finding" it, either with the set value inside the config file or the default value if it was not set in the config file switch to using pointer types in config instead. the pointer types are default initialized to nil, so it can at least determine if something is explicitly set or unset. write that into a function, and use it on config_helper.getConfigValueByPath
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the gcfg parser populates the fields with default values for that type, if that field is not present in the read config file. the config_helper was only checking if that field exists within that object instance, so it was always "finding" it, either with the set value inside the config file or the default value if it was not set in the config file
switch to using pointer types in config instead. the pointer types are default initialized to nil, so it can at least determine if something is explicitly set or unset. write that into a function, and use it on config_helper.getConfigValueByPath
the default enablement values for: livestatus, nagios spoolfile, and nagflux spoolfile are all true