Merged
Conversation
added 4 commits
February 9, 2026 13:45
- properly compare if the interface itself and its value inside is not nill before calling Stop() - add nil checks on the Stop() functions to see if the receiver pointer value is nil
- remove nil checks for receivers - remove nil checks while stopping and counting stoppables
sni
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intended to fix issues where using an interrupt like sigterm causes panic in the program. This is due to blindly calling Stop() on objects that were nil.
There was a nil check on the stoppables array, but that was not working. The solution is to not add objects to the stoppables array if they are nil.