feat: include AWS account ID in account display name#105
Open
c1-dev-bot[bot] wants to merge 1 commit into
Open
feat: include AWS account ID in account display name#105c1-dev-bot[bot] wants to merge 1 commit into
c1-dev-bot[bot] wants to merge 1 commit into
Conversation
Include the AWS account ID in parentheses alongside the account name in the resource display name. This makes account IDs visible and searchable in the ConductorOne app catalog for AWS SSO requests. Before: "Production" After: "Production (123456789012)" This applies to both SSO-enabled accounts (account.go) and IAM-only accounts (account_iam.go).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
account.go) and IAM-only accounts (account_iam.go)Before:
ProductionAfter:
Production (123456789012)The account ID was already stored in the resource profile (
aws_account_id) and used as the resource ID, but was not included in the display name that users see and search in the app catalog. This change surfaces it directly.Test plan
go build ./...)go test ./...)Automated PR Notice
This PR was automatically created by c1-dev-bot as a potential implementation.
This code requires: