feat: show AWS account names in multi-account connector#119
feat: show AWS account names in multi-account connector#119c1-dev-bot[bot] wants to merge 1 commit into
Conversation
Add aws_account_name to account profiles and IAM user profiles, and include account name in entitlement display names for better multi-account auditing and identification. Changes: - Add aws_account_name field to account resource profiles - Include account name prefix in entitlement display names (e.g. "MyAccount - AdminAccess Permission Set") - Add aws_account_id and aws_account_name to IAM user profiles when listing users in multi-account (Organizations) mode - Cache account name lookups via organizations:DescribeAccount Fixes: CXH-1524
| }) | ||
| if err != nil || resp.Account == nil { | ||
| return "" |
There was a problem hiding this comment.
🟡 Suggestion: This silently swallows the DescribeAccount error, making it hard to diagnose why account names are missing. A debug-level log here would turn this into a proper skip-and-continue pattern.
| }) | |
| if err != nil || resp.Account == nil { | |
| return "" | |
| if err != nil || resp.Account == nil { | |
| ctxzap.Extract(ctx).Debug("baton-aws: failed to describe account", zap.String("account_id", accountID), zap.Error(err)) | |
| return "" | |
| } |
Connector PR Review: feat: show AWS account names in multi-account connectorBlocking Issues: 0 | Suggestions: 1 | Threads Resolved: 0 Review SummaryThis PR adds AWS account name display to account resource profiles, entitlement display names, and IAM user profiles in multi-account mode. The entitlement display name change is safe because the entitlement ID and slug are independently set on lines 258-259 of Security IssuesNone found. Correctness IssuesNone found. Suggestions
Prompt for AI agents |
Summary
aws_account_nameto account resource profiles (previously only hadaws_account_arnandaws_account_id)"MyAccount - AdminAccess Permission Set"instead of"AdminAccess Permission Set"aws_account_idandaws_account_nameto IAM user profiles when listing users in multi-account (Organizations) mode, enabling per-account filtering and identification in reports/exportsorganizations:DescribeAccountto minimize API callsTest Plan
aws_account_namein their profileaws_account_idandaws_account_namein their profileFixes: CXH-1524
Automated PR Notice
This PR was automatically created by c1-dev-bot as a potential implementation.
This code requires: