chore: update baton-sdk to v0.7.16#7
Open
gontzess wants to merge 3 commits into
Open
Conversation
WalkthroughThese changes upgrade the baton-sdk dependency and introduce Discord bot configuration support. A new configuration schema is defined with a token field, with corresponding accessor methods auto-generated into a new file. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
gontzess
changed the title
gontzess
force-pushed
the
task-sdk-upgrade-batch-10
branch
4 times, most recently
from
05343c0 to
3fcff2c
Compare
gontzess
force-pushed
the
task-sdk-upgrade-batch-10
branch
from
3fcff2c to
9699a94
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@pkg/config/conf.gen.go`:
- Around line 10-23: The method findFieldByTag on type Discord currently calls
reflect.ValueOf(c).Elem() and will panic if the receiver *Discord is nil; add a
defensive nil check at the start of findFieldByTag (check if c == nil) and
return nil, false immediately when nil, so callers safely get no-value instead
of crashing; keep the rest of the logic (using reflect.ValueOf(c).Elem(),
t.NumField(), field.Tag.Get("mapstructure"), and v.Field(i).Interface())
unchanged.
🧹 Nitpick comments (1)
go.mod (1)
7-10: Move ruleguard dependencies to a tools.go file.These packages are only used in
tools/rules.go(which has//go:build ruleguardconstraints) and are not part of the production binary. Moving them to a dedicated tools.go file follows Go best practices and reduces the main module's dependency surface.♻️ Suggested approach
- github.com/ennyjfrick/ruleguard-logfatal v0.0.2 - github.com/quasilyte/go-ruleguard/dsl v0.3.23Add a tools-only file (example
tools.goat repo root)://go:build tools // +build tools package tools import ( _ "github.com/ennyjfrick/ruleguard-logfatal" _ "github.com/quasilyte/go-ruleguard/dsl" )
Comment on lines
+10
to
+23
| func (c *Discord) findFieldByTag(tagValue string) (any, bool) { | ||
| v := reflect.ValueOf(c).Elem() // Dereference pointer to struct | ||
| t := v.Type() | ||
|
|
||
| for i := 0; i < t.NumField(); i++ { | ||
| field := t.Field(i) | ||
| tag := field.Tag.Get("mapstructure") | ||
|
|
||
| if tag == tagValue { | ||
| return v.Field(i).Interface(), true | ||
| } | ||
| } | ||
| return nil, false | ||
| } |
There was a problem hiding this comment.
Guard against nil receiver to avoid panics in config accessors.
If *Discord is nil, reflect.ValueOf(c).Elem() panics. A defensive nil check prevents accidental crashes.
✅ Suggested fix (update generator)
func (c *Discord) findFieldByTag(tagValue string) (any, bool) {
+ if c == nil {
+ return nil, false
+ }
v := reflect.ValueOf(c).Elem() // Dereference pointer to struct
t := v.Type()📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| func (c *Discord) findFieldByTag(tagValue string) (any, bool) { | |
| v := reflect.ValueOf(c).Elem() // Dereference pointer to struct | |
| t := v.Type() | |
| for i := 0; i < t.NumField(); i++ { | |
| field := t.Field(i) | |
| tag := field.Tag.Get("mapstructure") | |
| if tag == tagValue { | |
| return v.Field(i).Interface(), true | |
| } | |
| } | |
| return nil, false | |
| } | |
| func (c *Discord) findFieldByTag(tagValue string) (any, bool) { | |
| if c == nil { | |
| return nil, false | |
| } | |
| v := reflect.ValueOf(c).Elem() // Dereference pointer to struct | |
| t := v.Type() | |
| for i := 0; i < t.NumField(); i++ { | |
| field := t.Field(i) | |
| tag := field.Tag.Get("mapstructure") | |
| if tag == tagValue { | |
| return v.Field(i).Interface(), true | |
| } | |
| } | |
| return nil, false | |
| } |
🤖 Prompt for AI Agents
In `@pkg/config/conf.gen.go` around lines 10 - 23, The method findFieldByTag on
type Discord currently calls reflect.ValueOf(c).Elem() and will panic if the
receiver *Discord is nil; add a defensive nil check at the start of
findFieldByTag (check if c == nil) and return nil, false immediately when nil,
so callers safely get no-value instead of crashing; keep the rest of the logic
(using reflect.ValueOf(c).Elem(), t.NumField(), field.Tag.Get("mapstructure"),
and v.Field(i).Interface()) unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Status
go build ./...passes)