[DAT-456] Add missing resource change events to baton-okta#153
Open
mj-palanker wants to merge 2 commits into
Open
[DAT-456] Add missing resource change events to baton-okta#153mj-palanker wants to merge 2 commits into
mj-palanker wants to merge 2 commits into
Conversation
Contributor
|
Claude finished @mj-palanker's task in 41s —— View job PR Review: [DAT-456] Add missing resource change events to baton-okta
Looks good! This is a clean, focused change that addresses two distinct issues: 1. Bug fix:
|
| Filter | Added Events |
|---|---|
GroupChangeFilter |
group.profile.update |
ApplicationLifecycleFilter |
application.lifecycle.activate, application.lifecycle.deactivate |
UserLifecycleFilter |
user.lifecycle.deactivate, user.lifecycle.suspend, user.lifecycle.unsuspend, user.lifecycle.reactivate |
These are all valid Okta System Log event types that represent meaningful resource state changes.
No concerns
- The existing
EventHandlerfunctions emit genericResourceChangeEvents, so they handle all these new event types correctly without needing handler changes. - The
TargetTypesfor each filter remain correct for the new events. - No new logic paths introduced — just expanded event matching sets.
LGTM 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's some missing transitions we currently aren't emitting events for.
also we apparently were filtering on the wrong event name for
app.lifecycle.create