Skip to content

[DAT-456] Add missing resource change events to baton-okta#153

Open
mj-palanker wants to merge 2 commits into
mainfrom
mjp/DAT-456
Open

[DAT-456] Add missing resource change events to baton-okta#153
mj-palanker wants to merge 2 commits into
mainfrom
mjp/DAT-456

Conversation

@mj-palanker
Copy link
Copy Markdown
Contributor

There's some missing transitions we currently aren't emitting events for.
also we apparently were filtering on the wrong event name for app.lifecycle.create

@mj-palanker mj-palanker requested a review from a team April 3, 2026 03:45
@linear
Copy link
Copy Markdown

linear Bot commented Apr 3, 2026

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 3, 2026

Claude finished @mj-palanker's task in 41s —— View job


PR Review: [DAT-456] Add missing resource change events to baton-okta

  • Gather context and read changed files
  • Analyze the diff against origin/main
  • Post review feedback

Looks good! This is a clean, focused change that addresses two distinct issues:

1. Bug fix: app.lifecycle.createapplication.lifecycle.create (line 135)

The previous event name app.lifecycle.create doesn't match the Okta event naming convention — all other application events use the application. prefix. This was silently causing create events to be missed. Good catch.

2. Missing lifecycle events

All three filters now cover important state transitions that were previously ignored:

Filter Added Events
GroupChangeFilter group.profile.update
ApplicationLifecycleFilter application.lifecycle.activate, application.lifecycle.deactivate
UserLifecycleFilter user.lifecycle.deactivate, user.lifecycle.suspend, user.lifecycle.unsuspend, user.lifecycle.reactivate

These are all valid Okta System Log event types that represent meaningful resource state changes.

No concerns

  • The existing EventHandler functions emit generic ResourceChangeEvents, so they handle all these new event types correctly without needing handler changes.
  • The TargetTypes for each filter remain correct for the new events.
  • No new logic paths introduced — just expanded event matching sets.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant