Return GRPC codes.InvalidArgument if JWK is invalid.#860
Open
ggreer wants to merge 2 commits into
Open
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| err := jwk.UnmarshalJSON(jwkBytes) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("jwk: failed to unmarshal jwk: %w", err) | ||
| return nil, status.Errorf(codes.InvalidArgument, "jwk: failed to unmarshal jwk: %v", err) |
Contributor
There was a problem hiding this comment.
🟡 Suggestion: No test covers the unmarshalJWK failure path. TestInvalidKeyType exercises an unsupported key type after successful unmarshal, not an unmarshal failure. Consider adding a test that passes invalid bytes to Encrypt and asserts status.Code(err) == codes.InvalidArgument.
Contributor
General PR Review: Return GRPC codes.InvalidArgument if JWK is invalid.Blocking Issues: 0 | Suggestions: 0 | Threads Resolved: 0 Review SummaryThe new commit adds a unit test for the Security IssuesNone found. Correctness IssuesNone found. SuggestionsNone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.