Skip to content

Remove journal_mode WAL pragmas from tests.#861

Open
ggreer wants to merge 1 commit into
mainfrom
ggreer/no-wal
Open

Remove journal_mode WAL pragmas from tests.#861
ggreer wants to merge 1 commit into
mainfrom
ggreer/no-wal

Conversation

@ggreer
Copy link
Copy Markdown
Contributor

@ggreer ggreer commented May 22, 2026

We don't use WAL mode in production anymore, so use the same mode in tests.

@ggreer ggreer requested a review from a team May 22, 2026 22:22
@github-actions
Copy link
Copy Markdown
Contributor

ghost commented May 22, 2026

General PR Review: Remove journal_mode WAL pragmas from tests.

Blocking Issues: 0 | Suggestions: 0 | Threads Resolved: 0
Review mode: full
View review run

Review Summary

This PR removes WithPragma("journal_mode", "WAL") from all test files across pkg/dotc1z/ and pkg/synccompactor/, aligning test SQLite configuration with production which no longer uses WAL mode. All 11 changed files are test-only; no production code, exported APIs, or behavior is affected. No issues found.

Security Issues

None found.

Correctness Issues

None found.

Suggestions

None.

Copy link
Copy Markdown
Contributor

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking issues found.

We don't use WAL mode in production anymore, so use the same mode in tests.
Copy link
Copy Markdown
Contributor

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking issues found.

@ggreer ggreer enabled auto-merge (squash) May 24, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant